PTAL
https://codereview.chromium.org/17881005/diff/1/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):
https://codereview.chromium.org/17881005/diff/1/src/heap-snapshot-generator.cc#newcode1000
src/heap-snapshot-generator.cc:1000: "native_context",
proxy->native_context(),
On 2013/06/27 16:26:00, Yury Semikhatsky wrote:
Can we have a test for this?
As far as I understand global object in Blink consists of 3 objects
[1] which
look as a single entity from the application's point of view. One of
them is
created to keep global object identity on navigation while the shadow
one
actually keeps all user properties. Which one of them is pointed at by
the
native_context link?
[1]
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/bindings/v8/V8WindowShell.cpp&sq=package:chromium&type=cs&l=183
Don't think checking that we've reported this the only propery of
JSGlobalProxy deserves a test.
https://codereview.chromium.org/17881005/diff/1/src/heap-snapshot-generator.cc#newcode1767
src/heap-snapshot-generator.cc:1767: CHECK(global ==
context->global_object());
On 2013/06/28 09:42:18, Yury Semikhatsky wrote:
Ok, I looked more closely at how we setup global object in
bootstraper.cc, in
particular the inner global object [1] and I think we should use
context->global_object() instead.
[1]
https://code.google.com/p/chromium/codesearch#chromium/src/v8/src/bootstrapper.cc&q=Genesis::HookUpInnerGlobal&sq=package:chromium&type=cs&l=802
Done.
https://codereview.chromium.org/17881005/diff/1/src/heap-snapshot-generator.cc#newcode1770
src/heap-snapshot-generator.cc:1770: is_debug_object =
Isolate::Current()->debug()->IsDebugGlobal(global);
On 2013/06/27 16:26:00, Yury Semikhatsky wrote:
Please use heap_->isolate() instead of Isolate::Current()
Done.
https://codereview.chromium.org/17881005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
