Reviewers: Hannes Payer,
Message:
Hi Hannes, here is the fix for the gcstress issue you saw. thanks!
--Michael
Description:
Test fix - array-feedback.js has a test that only make sense when
running crankshaft. Allow the test to tolerate --nocrankshaft.
BUG=
Please review this at https://codereview.chromium.org/18328002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M test/mjsunit/array-feedback.js
Index: test/mjsunit/array-feedback.js
diff --git a/test/mjsunit/array-feedback.js b/test/mjsunit/array-feedback.js
index
c602018d94ac198b921784a8402f6ab65b2b0496..d1b3062eb065d4738ac4367b8233abe19ecc8afe
100644
--- a/test/mjsunit/array-feedback.js
+++ b/test/mjsunit/array-feedback.js
@@ -179,13 +179,16 @@ if (support_smi_only_arrays) {
a[0] = 3.5;
%OptimizeFunctionOnNextCall(create0);
create0();
- create0();
- b = create0();
- assertKind(elements_kind.fast_smi_only, b);
- b[0] = 3.5;
- c = create0();
- assertKind(elements_kind.fast_double, c);
- assertTrue(2 != %GetOptimizationStatus(create0));
+ // This test only makes sense if crankshaft is allowed
+ if (4 != %GetOptimizationStatus(create0)) {
+ create0();
+ b = create0();
+ assertKind(elements_kind.fast_smi_only, b);
+ b[0] = 3.5;
+ c = create0();
+ assertKind(elements_kind.fast_double, c);
+ assertTrue(2 != %GetOptimizationStatus(create0));
+ }
})();
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
