LGTM with nits.
https://codereview.chromium.org/18310003/diff/2001/tools/grokdump.py
File tools/grokdump.py (right):
https://codereview.chromium.org/18310003/diff/2001/tools/grokdump.py#newcode42
tools/grokdump.py:42: import datetime
nit: Can we alpha-sort the imports?
https://codereview.chromium.org/18310003/diff/2001/tools/grokdump.py#newcode2112
tools/grokdump.py:2112: def GetModuleDetails(reader, module):
nit: Can we rename this to PrintModuleDetails, I think that better
describes semantics?
https://codereview.chromium.org/18310003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
