Revision: 15417
Author: [email protected]
Date: Mon Jul 1 05:57:15 2013
Log: Ensure CheckInitialized is present independent of define.
This makes sure that the same symbols are present, independent of which
defines have been used while building V8. Otherwise only embedders with
compatible defines would be able to link against that binary.
[email protected]
BUG=chromium:255779
Review URL: https://codereview.chromium.org/18305004
http://code.google.com/p/v8/source/detail?r=15417
Modified:
/branches/bleeding_edge/include/v8.h
/branches/bleeding_edge/src/api.cc
=======================================
--- /branches/bleeding_edge/include/v8.h Mon Jul 1 05:32:52 2013
+++ /branches/bleeding_edge/include/v8.h Mon Jul 1 05:57:15 2013
@@ -5401,11 +5401,12 @@
static const int kUndefinedOddballKind = 5;
static const int kNullOddballKind = 3;
+ static void CheckInitializedImpl(v8::Isolate* isolate);
+ V8_INLINE(static void CheckInitialized(v8::Isolate* isolate)) {
#ifdef V8_ENABLE_CHECKS
- static void CheckInitialized(v8::Isolate* isolate);
-#else
- static void CheckInitialized(v8::Isolate* isolate) { }
+ CheckInitializedImpl(isolate);
#endif
+ }
V8_INLINE(static bool HasHeapObjectTag(internal::Object* value)) {
return ((reinterpret_cast<intptr_t>(value) & kHeapObjectTagMask) ==
=======================================
--- /branches/bleeding_edge/src/api.cc Mon Jul 1 03:54:39 2013
+++ /branches/bleeding_edge/src/api.cc Mon Jul 1 05:57:15 2013
@@ -2934,14 +2934,12 @@
}
-#ifdef V8_ENABLE_CHECKS
-void i::Internals::CheckInitialized(v8::Isolate* external_isolate) {
+void i::Internals::CheckInitializedImpl(v8::Isolate* external_isolate) {
i::Isolate* isolate = reinterpret_cast<i::Isolate*>(external_isolate);
ApiCheck(isolate != NULL && isolate->IsInitialized() && !i::V8::IsDead(),
"v8::internal::Internals::CheckInitialized()",
"Isolate is not initialized or V8 has died");
}
-#endif
void External::CheckCast(v8::Value* that) {
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
