On 2013/07/01 13:42:57, Jakob wrote:
LGTM with nits.
Adding mvstanton to verify that this way of detecting uninitialized array
literals makes sense.
https://codereview.chromium.org/18263002/diff/2001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/18263002/diff/2001/src/hydrogen.cc#newcode5771
src/hydrogen.cc:5771: bool uninitialized= false;
nit: spaces around '='
https://codereview.chromium.org/18263002/diff/2001/src/hydrogen.cc#newcode5870
src/hydrogen.cc:5870: {
nit: the opening '{' can go on the line before, resulting in one level
less
indentation
Refine code based on comments, thanks
https://codereview.chromium.org/18263002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
