lgtm
https://codereview.chromium.org/17642009/diff/11001/test/cctest/test-profile-generator.cc
File test/cctest/test-profile-generator.cc (right):
https://codereview.chromium.org/17642009/diff/11001/test/cctest/test-profile-generator.cc#newcode912
test/cctest/test-profile-generator.cc:912: // don't appear in the stack
trace.
I think we should be testing with inlining on as well to make sure
script id is correct after inlining.
https://codereview.chromium.org/17642009/diff/11001/test/cctest/test-profile-generator.cc#newcode920
test/cctest/test-profile-generator.cc:920: context->Enter();
Please use LocalContext env(config); instead, it would save some typing
and would be more in line with other profiler tests.
https://codereview.chromium.org/17642009/diff/11001/test/cctest/test-profile-generator.cc#newcode933
test/cctest/test-profile-generator.cc:933: CpuProfile* profile =
profiler->GetProfile(NULL, 0);
Why don't we use public API here?
https://codereview.chromium.org/17642009/diff/11001/test/cctest/test-profile-generator.cc#newcode945
test/cctest/test-profile-generator.cc:945: current = PickChild(current,
"(anonymous function)");
Please use i::ProfilerGenerator::kAnonymousFunction instead/
https://codereview.chromium.org/17642009/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
