LGTM. While you're here, you can fix a few typos :-)
https://codereview.chromium.org/18487003/diff/1/src/hydrogen-uint32-analysis.cc
File src/hydrogen-uint32-analysis.cc (right):
https://codereview.chromium.org/18487003/diff/1/src/hydrogen-uint32-analysis.cc#newcode67
src/hydrogen-uint32-analysis.cc:67: // Encountered phis are
optimisitically treated as safe uint32 uses,
nit: optimistically
https://codereview.chromium.org/18487003/diff/1/src/hydrogen-uint32-analysis.cc#newcode69
src/hydrogen-uint32-analysis.cc:69: // path will be performed later by
UnmarkUnsafePhis to clear kUint32 from
nit: s/path/pass/
https://codereview.chromium.org/18487003/diff/1/src/hydrogen-uint32-analysis.cc#newcode70
src/hydrogen-uint32-analysis.cc:70: // phis that are not actually
uint32-safe (it requries fix point iteration).
nit: requires
https://codereview.chromium.org/18487003/diff/1/src/hydrogen-uint32-analysis.cc#newcode78
src/hydrogen-uint32-analysis.cc:78: // There is a phi use of this value
from a phis that is not yet
nit: "from a phi that..."
https://codereview.chromium.org/18487003/diff/1/src/hydrogen-uint32-analysis.cc#newcode96
src/hydrogen-uint32-analysis.cc:96: // There is a phi use of this value
from a phis that is not yet
nit: "from a phi that..."
https://codereview.chromium.org/18487003/diff/1/src/hydrogen-uint32-analysis.cc#newcode119
src/hydrogen-uint32-analysis.cc:119: // Lazyly mark constants that fit
into uint32 range with kUint32 flag.
nit: Lazily
https://codereview.chromium.org/18487003/diff/1/src/hydrogen-uint32-analysis.cc#newcode190
src/hydrogen-uint32-analysis.cc:190: // Check if any operands to safe
phies were unmarked
nit: s/phies/phis/
https://codereview.chromium.org/18487003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
