LGTM with one nit (the inline comment).
https://codereview.chromium.org/18508002/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/18508002/diff/1/src/hydrogen.cc#newcode1248
src/hydrogen.cc:1248: length->set_type(HType::Smi());
AddLoadFixedArrayLength already sets the type to Smi.
Wouldn't it be better to set the Smi type in the is_js_array branch
above, and here maybe just ASSERT that the type is Smi?
https://codereview.chromium.org/18508002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
