Revision: 15461
Author:   [email protected]
Date:     Wed Jul  3 02:47:22 2013
Log:      Don't return frame by reference in ProcessTopOptimizedFrame.

[email protected]

Review URL: https://codereview.chromium.org/18592006
http://code.google.com/p/v8/source/detail?r=15461

Modified:
 /branches/bleeding_edge/src/mark-compact.cc

=======================================
--- /branches/bleeding_edge/src/mark-compact.cc Tue Jul  2 08:15:58 2013
+++ /branches/bleeding_edge/src/mark-compact.cc Wed Jul  3 02:47:22 2013
@@ -2181,28 +2181,20 @@
 }


-static StackFrame* TopOptimizedFrame(Isolate* isolate) {
-  for (StackFrameIterator it(isolate, isolate->thread_local_top());
+void MarkCompactCollector::ProcessTopOptimizedFrame(ObjectVisitor* visitor) {
+  for (StackFrameIterator it(isolate(), isolate()->thread_local_top());
        !it.done(); it.Advance()) {
     if (it.frame()->type() == StackFrame::JAVA_SCRIPT) {
-      return NULL;
+      return;
     }
     if (it.frame()->type() == StackFrame::OPTIMIZED) {
-      return it.frame();
-    }
-  }
-  return NULL;
-}
-
-
-void MarkCompactCollector::ProcessTopOptimizedFrame(ObjectVisitor* visitor) {
-  StackFrame* frame = TopOptimizedFrame(isolate());
-  if (frame != NULL) {
-    Code* code = frame->LookupCode();
-    if (!code->CanDeoptAt(frame->pc())) {
-      code->CodeIterateBody(visitor);
+      Code* code = it.frame()->LookupCode();
+      if (!code->CanDeoptAt(it.frame()->pc())) {
+        code->CodeIterateBody(visitor);
+      }
+      ProcessMarkingDeque();
+      return;
     }
-    ProcessMarkingDeque();
   }
 }

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to