[v8-dev] Remove #include "cpu-profiler-inl.h" from v8.h (issue 18522004)

Wed, 03 Jul 2013 03:32:10 -0700 

Reviewers: loislo, Jakob, Yang,

Description:
Remove #include "cpu-profiler-inl.h" from v8.h

This significantly reduces amount of files to be recompiled after changes in
cpu-profiler.h and its dependencies.

BUG=None

Please review this at https://codereview.chromium.org/18522004/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files:
  M src/api.cc
  M src/arm/macro-assembler-arm.cc
  M src/arm/regexp-macro-assembler-arm.cc
  M src/builtins.cc
  M src/code-stubs.cc
  M src/codegen.cc
  M src/compiler.cc
  M src/handles.h
  M src/heap-snapshot-generator.h
  M src/heap.cc
  M src/ia32/macro-assembler-ia32.cc
  M src/ia32/regexp-macro-assembler-ia32.cc
  M src/isolate.cc
  M src/log-inl.h
  M src/log.cc
  M src/mark-compact.cc
  M src/mips/macro-assembler-mips.cc
  M src/objects.h
  M src/optimizing-compiler-thread.h
  M src/profile-generator.cc
  M src/runtime.cc
  M src/sampler.h
  M src/sampler.cc
  M src/spaces.h
  M src/stub-cache.cc
  M src/v8.h
  M src/x64/macro-assembler-x64.cc
  M src/x64/regexp-macro-assembler-x64.cc
  M test/cctest/test-api.cc
  M test/cctest/test-log-stack-tracer.cc
  M test/cctest/test-profile-generator.cc


Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index af897057afd10f28d3b48bbce565073d78ab254b..0301156ace744a24143bc262e9b42e824db696d6 100644 
--- a/src/api.cc
+++ b/src/api.cc
@@ -38,6 +38,7 @@
 #include "compiler.h"
 #include "conversions-inl.h"
 #include "counters.h"
+#include "cpu-profiler.h"
 #include "debug.h"
 #include "deoptimizer.h"
 #include "execution.h"
Index: src/arm/macro-assembler-arm.cc
diff --git a/src/arm/macro-assembler-arm.cc b/src/arm/macro-assembler-arm.cc
index 9e4dc403e504d43476017884fdd751eb88f7b2a5..cce20ffd6ac51c9600e26e78b464989681474281 100644 
--- a/src/arm/macro-assembler-arm.cc
+++ b/src/arm/macro-assembler-arm.cc
@@ -33,6 +33,7 @@

 #include "bootstrapper.h"
 #include "codegen.h"
+#include "cpu-profiler.h"
 #include "debug.h"
 #include "runtime.h"

Index: src/arm/regexp-macro-assembler-arm.cc
diff --git a/src/arm/regexp-macro-assembler-arm.cc b/src/arm/regexp-macro-assembler-arm.cc index 0acb7376b7480e01f28e731cdcfefd788abeca49..189ea8d777989e85d708bffb509b010445994c1f 100644 
--- a/src/arm/regexp-macro-assembler-arm.cc
+++ b/src/arm/regexp-macro-assembler-arm.cc
@@ -29,6 +29,7 @@

 #if V8_TARGET_ARCH_ARM

+#include "cpu-profiler.h"
 #include "unicode.h"
 #include "log.h"
 #include "code-stubs.h"
Index: src/builtins.cc
diff --git a/src/builtins.cc b/src/builtins.cc
index 5cc791515bc128b4ab788a9fa3e9bc39efb9817b..be04ddf53d449d3b13614ed61026e9ee6a599886 100644 
--- a/src/builtins.cc
+++ b/src/builtins.cc
@@ -31,6 +31,7 @@
 #include "arguments.h"
 #include "bootstrapper.h"
 #include "builtins.h"
+#include "cpu-profiler.h"
 #include "gdb-jit.h"
 #include "ic-inl.h"
 #include "heap-profiler.h"
Index: src/code-stubs.cc
diff --git a/src/code-stubs.cc b/src/code-stubs.cc
index 2d94ec978e098da76d89aedb2b41c48d1d5b2d5d..2ed2ba3c66413e68fc7f4b30f528f502fb5ee3fb 100644 
--- a/src/code-stubs.cc
+++ b/src/code-stubs.cc
@@ -29,6 +29,7 @@

 #include "bootstrapper.h"
 #include "code-stubs.h"
+#include "cpu-profiler.h"
 #include "stub-cache.h"
 #include "factory.h"
 #include "gdb-jit.h"
Index: src/codegen.cc
diff --git a/src/codegen.cc b/src/codegen.cc
index 7328e4015c390612aee0cbd4fc89665769f911fc..8029d2f8828bef644ae46025a7d74b82f3113281 100644 
--- a/src/codegen.cc
+++ b/src/codegen.cc
@@ -30,6 +30,7 @@
 #include "bootstrapper.h"
 #include "codegen.h"
 #include "compiler.h"
+#include "cpu-profiler.h"
 #include "debug.h"
 #include "prettyprinter.h"
 #include "rewriter.h"
Index: src/compiler.cc
diff --git a/src/compiler.cc b/src/compiler.cc
index 76c60176ca3fb577ccbb1089832c5a8530dfd672..8edb41d7240d6378ad8818f5222ac54dfe1f7286 100644 
--- a/src/compiler.cc
+++ b/src/compiler.cc
@@ -32,6 +32,7 @@
 #include "bootstrapper.h"
 #include "codegen.h"
 #include "compilation-cache.h"
+#include "cpu-profiler.h"
 #include "debug.h"
 #include "deoptimizer.h"
 #include "full-codegen.h"
Index: src/handles.h
diff --git a/src/handles.h b/src/handles.h
index 52e9752e4442607fd34094b4a42c92c43e95d9c2..5976b758e1f6fc9f28a7c04ef1dd96282cc92a95 100644 
--- a/src/handles.h
+++ b/src/handles.h
@@ -30,6 +30,7 @@

 #include "allocation.h"
 #include "apiutils.h"
+#include "objects.h"

 namespace v8 {
 namespace internal {
Index: src/heap-snapshot-generator.h
diff --git a/src/heap-snapshot-generator.h b/src/heap-snapshot-generator.h
index d3c8f1b639d8e18c0244836f91a61e87ae117417..84ad089a084f2f1633107795f41ca66fbea423bb 100644 
--- a/src/heap-snapshot-generator.h
+++ b/src/heap-snapshot-generator.h
@@ -28,6 +28,8 @@
 #ifndef V8_HEAP_SNAPSHOT_GENERATOR_H_
 #define V8_HEAP_SNAPSHOT_GENERATOR_H_

+#include "profile-generator-inl.h"
+
 namespace v8 {
 namespace internal {

Index: src/heap.cc
diff --git a/src/heap.cc b/src/heap.cc
index 3fac6018b02a2f4db95a9aa1ba5a5025de275a37..9d1ac8c1ed4be6e07938d0699dd8cc52d50d8236 100644 
--- a/src/heap.cc
+++ b/src/heap.cc
@@ -32,6 +32,7 @@
 #include "bootstrapper.h"
 #include "codegen.h"
 #include "compilation-cache.h"
+#include "cpu-profiler.h"
 #include "debug.h"
 #include "deoptimizer.h"
 #include "global-handles.h"
Index: src/ia32/macro-assembler-ia32.cc
diff --git a/src/ia32/macro-assembler-ia32.cc b/src/ia32/macro-assembler-ia32.cc index 63477aa2634e0287c00398bc76e240412bc38293..a9a0268aef476854544a1f596f6e4301d42c04c7 100644 
--- a/src/ia32/macro-assembler-ia32.cc
+++ b/src/ia32/macro-assembler-ia32.cc
@@ -31,6 +31,7 @@

 #include "bootstrapper.h"
 #include "codegen.h"
+#include "cpu-profiler.h"
 #include "debug.h"
 #include "runtime.h"
 #include "serialize.h"
Index: src/ia32/regexp-macro-assembler-ia32.cc
diff --git a/src/ia32/regexp-macro-assembler-ia32.cc b/src/ia32/regexp-macro-assembler-ia32.cc index 54fe8bf2ea4a31b624bde42668683e7ae1e6d746..f478e574f5c19299b44cfc37736afe8e3ce1ffa8 100644 
--- a/src/ia32/regexp-macro-assembler-ia32.cc
+++ b/src/ia32/regexp-macro-assembler-ia32.cc
@@ -29,6 +29,7 @@

 #if V8_TARGET_ARCH_IA32

+#include "cpu-profiler.h"
 #include "unicode.h"
 #include "log.h"
 #include "regexp-stack.h"
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index fec3dc66ab4260b63b6e8a6023d34961e53536bc..edfe2976581fbe56148d7c1647c3b54904be91ac 100644 
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -34,6 +34,7 @@
 #include "bootstrapper.h"
 #include "codegen.h"
 #include "compilation-cache.h"
+#include "cpu-profiler.h"
 #include "debug.h"
 #include "deoptimizer.h"
 #include "heap-profiler.h"
@@ -46,6 +47,7 @@
 #include "platform.h"
 #include "regexp-stack.h"
 #include "runtime-profiler.h"
+#include "sampler.h"
 #include "scopeinfo.h"
 #include "serialize.h"
 #include "simulator.h"
Index: src/log-inl.h
diff --git a/src/log-inl.h b/src/log-inl.h
index 8aebbc7dde0beb28f710af8915975494cf3cf98e..7f653cb7283ad90cc692b80bd1533f979728b724 100644 
--- a/src/log-inl.h
+++ b/src/log-inl.h
@@ -29,7 +29,6 @@
 #define V8_LOG_INL_H_

 #include "log.h"
-#include "cpu-profiler.h"

 namespace v8 {
 namespace internal {
Index: src/log.cc
diff --git a/src/log.cc b/src/log.cc
index 7fd6cf47b715fff7ea87945f30cbb30ccf9fa786..6ed2d365eaecae4201ca16c4a19f34b16abbf7c1 100644 
--- a/src/log.cc
+++ b/src/log.cc
@@ -31,6 +31,7 @@

 #include "bootstrapper.h"
 #include "code-stubs.h"
+#include "cpu-profiler.h"
 #include "deoptimizer.h"
 #include "global-handles.h"
 #include "log.h"
Index: src/mark-compact.cc
diff --git a/src/mark-compact.cc b/src/mark-compact.cc
index 449e6556e42f62ce5f23bfd45372426a0bfecb69..388076bcbd3f8fa939b760f7d66b5a62c0e3024f 100644 
--- a/src/mark-compact.cc
+++ b/src/mark-compact.cc
@@ -29,6 +29,7 @@

 #include "code-stubs.h"
 #include "compilation-cache.h"
+#include "cpu-profiler.h"
 #include "deoptimizer.h"
 #include "execution.h"
 #include "gdb-jit.h"
Index: src/mips/macro-assembler-mips.cc
diff --git a/src/mips/macro-assembler-mips.cc b/src/mips/macro-assembler-mips.cc index 58903477377bb7d767789eb5619c2b6cc55b58dc..47e6ff93c71e6092eafee215c10b298f2d46a6d7 100644 
--- a/src/mips/macro-assembler-mips.cc
+++ b/src/mips/macro-assembler-mips.cc
@@ -33,6 +33,7 @@

 #include "bootstrapper.h"
 #include "codegen.h"
+#include "cpu-profiler.h"
 #include "debug.h"
 #include "runtime.h"

Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index 68eda124c67c77f67f26a4abcaac5f5712239f80..416ed7fcda6ba35b5144f95144f10348225a5723 100644 
--- a/src/objects.h
+++ b/src/objects.h
@@ -32,6 +32,7 @@
 #include "assert-scope.h"
 #include "builtins.h"
 #include "elements-kind.h"
+#include "flags.h"
 #include "list.h"
 #include "property-details.h"
 #include "smart-pointers.h"
Index: src/optimizing-compiler-thread.h
diff --git a/src/optimizing-compiler-thread.h b/src/optimizing-compiler-thread.h index 699c76dcb8849b5ac89f51d8bc266d2b5d2e39d8..275ceb40b711ccecf4ee4937355fed1eb8f23c61 100644 
--- a/src/optimizing-compiler-thread.h
+++ b/src/optimizing-compiler-thread.h
@@ -31,7 +31,7 @@
 #include "atomicops.h"
 #include "flags.h"
 #include "platform.h"
-#include "unbound-queue.h"
+#include "unbound-queue-inl.h"

 namespace v8 {
 namespace internal {
Index: src/profile-generator.cc
diff --git a/src/profile-generator.cc b/src/profile-generator.cc
index 10bd94e7a374cf889312728b7b39c1101ebba9a4..78b05c57e479c8969154770168ce6ad45e2ed8ec 100644 
--- a/src/profile-generator.cc
+++ b/src/profile-generator.cc
@@ -30,11 +30,12 @@
 #include "profile-generator-inl.h"

 #include "compiler.h"
+#include "debug.h"
+#include "sampler.h"
 #include "global-handles.h"
 #include "scopeinfo.h"
 #include "unicode.h"
 #include "zone-inl.h"
-#include "debug.h"

 namespace v8 {
 namespace internal {
Index: src/runtime.cc
diff --git a/src/runtime.cc b/src/runtime.cc
index 869c17bf784495cc1c354e9cdce0c0a8e4e3df0e..99308ba87349f37403410bdd76a00bad72041a95 100644 
--- a/src/runtime.cc
+++ b/src/runtime.cc
@@ -38,6 +38,7 @@
 #include "compilation-cache.h"
 #include "compiler.h"
 #include "cpu.h"
+#include "cpu-profiler.h"
 #include "dateparser-inl.h"
 #include "debug.h"
 #include "deoptimizer.h"
Index: src/sampler.cc
diff --git a/src/sampler.cc b/src/sampler.cc
index 63d0aa88cc722468602f1da7ac023071a268c76c..c3268a3d73e9f963faa70d5483ea302f3d055051 100644 
--- a/src/sampler.cc
+++ b/src/sampler.cc
@@ -25,6 +25,8 @@
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

+#include "sampler.h"
+
 #if defined(__linux__) || defined(__FreeBSD__) || defined(__OpenBSD__) \
     || defined(__NetBSD__) || defined(__sun) || defined(__ANDROID__) \
     || defined(__native_client__)
@@ -60,6 +62,8 @@

 #include "v8.h"

+#include "cpu-profiler.h"
+#include "flags.h"
 #include "frames-inl.h"
 #include "log.h"
 #include "platform.h"
Index: src/sampler.h
diff --git a/src/sampler.h b/src/sampler.h
index 3875a29e663e1bb8c797553515e820f56eb7ff14..57e82dcd3fa4233450ea398eb78373d39069859b 100644 
--- a/src/sampler.h
+++ b/src/sampler.h
@@ -29,6 +29,7 @@
 #define V8_SAMPLER_H_

 #include "atomicops.h"
+#include "frames.h"
 #include "v8globals.h"

 namespace v8 {
Index: src/spaces.h
diff --git a/src/spaces.h b/src/spaces.h
index 5b27542c3c30945229e71e7b1285f00d6f2550b6..dda55919c4e34e7efba7621747dc0dc39e789354 100644 
--- a/src/spaces.h
+++ b/src/spaces.h
@@ -32,6 +32,7 @@
 #include "hashmap.h"
 #include "list.h"
 #include "log.h"
+#include "v8utils.h"

 namespace v8 {
 namespace internal {
Index: src/stub-cache.cc
diff --git a/src/stub-cache.cc b/src/stub-cache.cc
index e0839f13d2b4d33cfe2edbb00994209e2d34e387..62ac2c873bf006d21c63693cfb388552232f917d 100644 
--- a/src/stub-cache.cc
+++ b/src/stub-cache.cc
@@ -31,6 +31,7 @@
 #include "arguments.h"
 #include "ast.h"
 #include "code-stubs.h"
+#include "cpu-profiler.h"
 #include "gdb-jit.h"
 #include "ic-inl.h"
 #include "stub-cache.h"
Index: src/v8.h
diff --git a/src/v8.h b/src/v8.h
index 52fb98a5617706f3d7510da53c328f5a92669b07..be421f9f88666d8ab51f502f5b29f43321da986a 100644 
--- a/src/v8.h
+++ b/src/v8.h
@@ -64,7 +64,6 @@
 #include "incremental-marking-inl.h"
 #include "mark-compact-inl.h"
 #include "log-inl.h"
-#include "cpu-profiler-inl.h"
 #include "handles-inl.h"
 #include "heap-snapshot-generator-inl.h"
 #include "zone-inl.h"
Index: src/x64/macro-assembler-x64.cc
diff --git a/src/x64/macro-assembler-x64.cc b/src/x64/macro-assembler-x64.cc
index fdeee3131c2b44cf3bb6e4ff4eae3145a7bb99c6..7205b5a3a20b8bbbf21416393468396664967959 100644 
--- a/src/x64/macro-assembler-x64.cc
+++ b/src/x64/macro-assembler-x64.cc
@@ -31,6 +31,7 @@

 #include "bootstrapper.h"
 #include "codegen.h"
+#include "cpu-profiler.h"
 #include "assembler-x64.h"
 #include "macro-assembler-x64.h"
 #include "serialize.h"
Index: src/x64/regexp-macro-assembler-x64.cc
diff --git a/src/x64/regexp-macro-assembler-x64.cc b/src/x64/regexp-macro-assembler-x64.cc index e1d4a2d88d66625f69fe39439da51ae1da3e1fb1..106ffb76da58fbdfab942a8442672199f0115bcd 100644 
--- a/src/x64/regexp-macro-assembler-x64.cc
+++ b/src/x64/regexp-macro-assembler-x64.cc
@@ -29,6 +29,7 @@

 #if V8_TARGET_ARCH_X64

+#include "cpu-profiler.h"
 #include "serialize.h"
 #include "unicode.h"
 #include "log.h"
Index: test/cctest/test-api.cc
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index f8b492b785176b7383f7d27cb2d003b353c50e45..82f973d89b0104fc3dd23039d8df5f3af8e628ac 100644 
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -38,16 +38,17 @@

 #include "api.h"
 #include "arguments.h"
-#include "isolate.h"
+#include "cctest.h"
 #include "compilation-cache.h"
+#include "cpu-profiler.h"
 #include "execution.h"
+#include "isolate.h"
 #include "objects.h"
-#include "snapshot.h"
-#include "platform.h"
-#include "utils.h"
-#include "cctest.h"
 #include "parser.h"
+#include "platform.h"
+#include "snapshot.h"
 #include "unicode-inl.h"
+#include "utils.h"

 static const bool kLogThreading = false;

Index: test/cctest/test-log-stack-tracer.cc
diff --git a/test/cctest/test-log-stack-tracer.cc b/test/cctest/test-log-stack-tracer.cc index 4333498d8b1fe987bd49c50a7f438de2c311790d..567197586f3f7f6b441a48fad3d61b8773fe6aa8 100644 
--- a/test/cctest/test-log-stack-tracer.cc
+++ b/test/cctest/test-log-stack-tracer.cc
@@ -32,11 +32,12 @@
 #include "v8.h"

 #include "api.h"
-#include "codegen.h"
-#include "log.h"
-#include "isolate.h"
 #include "cctest.h"
+#include "codegen.h"
 #include "disassembler.h"
+#include "isolate.h"
+#include "log.h"
+#include "sampler.h"
 #include "vm-state-inl.h"

 using v8::Function;
Index: test/cctest/test-profile-generator.cc
diff --git a/test/cctest/test-profile-generator.cc b/test/cctest/test-profile-generator.cc index dfcc75ce13ff1f117f88d85ad94001e71f6aab62..7472669e32b23acc990a9c2e4bd630ffbd5c7b04 100644 
--- a/test/cctest/test-profile-generator.cc
+++ b/test/cctest/test-profile-generator.cc
@@ -30,6 +30,7 @@
 #include "v8.h"
 #include "profile-generator-inl.h"
 #include "cctest.h"
+#include "cpu-profiler.h"
 #include "../include/v8-profiler.h"

 using i::CodeEntry;


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group. 
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to