Reviewers: Jakob, loislo,
Description:
Relax test expectations for test-cpu-profiler/FunctionApplySample
The profile may look a bit different on the bots (see below). We expected
this
only under GC stress testing, the change makes regular expectations the
same.
[Top down]:
68 0 (root) [-1] #0 1
1 1 (program) [-1] #0 2
67 65 start [-1] #16 3
2 0 (unresolved function) [-1] #0 4
2 2 apply [-1] #0 5
BUG=None
[email protected]
Please review this at https://codereview.chromium.org/18331012/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M test/cctest/test-cpu-profiler.cc
Index: test/cctest/test-cpu-profiler.cc
diff --git a/test/cctest/test-cpu-profiler.cc
b/test/cctest/test-cpu-profiler.cc
index
97636a35ff0ea313507176717b5951be060e4162..0ae1a9ef7ee875a09bd0fe4feadfc743fd6c7625
100644
--- a/test/cctest/test-cpu-profiler.cc
+++ b/test/cctest/test-cpu-profiler.cc
@@ -1169,13 +1169,7 @@ TEST(FunctionApplySample) {
CheckChildrenNames(root, names);
}
- // In case of GC stress tests all samples may be in GC phase and there
- // won't be |start| node in the profile.
- bool is_gc_stress_testing =
- (i::FLAG_gc_interval != -1) || i::FLAG_stress_compaction;
-
const v8::CpuProfileNode* startNode = FindChild(root, "start");
- CHECK(is_gc_stress_testing || startNode);
if (startNode) {
{
ScopedVector<v8::Handle<v8::String> > names(2);
@@ -1185,7 +1179,6 @@ TEST(FunctionApplySample) {
}
const v8::CpuProfileNode* testNode = FindChild(startNode, "test");
- CHECK(is_gc_stress_testing || testNode);
if (testNode) {
ScopedVector<v8::Handle<v8::String> > names(2);
names[0] = v8::String::New("bar");
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
