LGTM with comments.
https://codereview.chromium.org/18550002/diff/5001/src/factory.h
File src/factory.h (right):
https://codereview.chromium.org/18550002/diff/5001/src/factory.h#newcode572
src/factory.h:572: class IdempotentHandleToPointerCodeTrampoline {
nit: s/HandleToPointer/PointerToHandle/
https://codereview.chromium.org/18550002/diff/5001/src/factory.h#newcode579
src/factory.h:579: int scavenges = isolate_->heap()->gc_count();
nit: Since this doesn't only count minor GCs, but all GCs, let's rename
this local variable s/scavenges/collections/. Same comment applies
several times below.
https://codereview.chromium.org/18550002/diff/5001/src/factory.h#newcode589
src/factory.h:589: MaybeObject* result = (*function)();
I think the called function is not allowed to return a MaybeObject of
it's own. Handlified code has to either return Handle<T> or something
that is below Object in the type hierarchy. Can we s/MaybeObject/Object/
here? Same comment applies several times
below.
https://codereview.chromium.org/18550002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
