https://codereview.chromium.org/18695004/diff/3001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/18695004/diff/3001/include/v8.h#newcode2492
include/v8.h:2492: #ifndef V8_ARRAY_BUFFER_VIEW_INTERNAL_FIELD_COUNT
I'm not sure why you conditionally define a macro here. Is the macro
potentially defined somewhere else (maybe with a -D for testing?) If so,
it would be nice to have a sentence explaining why.
https://codereview.chromium.org/18695004/diff/3001/include/v8.h#newcode2525
include/v8.h:2525: V8_ARRAY_BUFFER_VIEW_INTERNAL_FIELD_COUNT;
BTW, where are these internal fields defined?
https://codereview.chromium.org/18695004/diff/3001/test/cctest/test-api.cc
File test/cctest/test-api.cc (right):
https://codereview.chromium.org/18695004/diff/3001/test/cctest/test-api.cc#newcode2557
test/cctest/test-api.cc:2557: static void
CheckInternalFields(v8::Handle<T> value) {
rename to CheckInternalFieldsAreZero?
https://codereview.chromium.org/18695004/diff/3001/test/cctest/test-api.cc#newcode2574
test/cctest/test-api.cc:2574: CheckInternalFields<v8::ArrayBuffer>(ab);
Is C++ not able to infer the type argument <v8::ArrayBuffer> here?
https://codereview.chromium.org/18695004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
