https://codereview.chromium.org/18712002/diff/18001/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):
https://codereview.chromium.org/18712002/diff/18001/src/code-stubs-hydrogen.cc#newcode781
src/code-stubs-hydrogen.cc:781: AddInstruction(new(zone())
HPushArgument(GetParameter(0)));
Add<HPushArgument>(GetParameter(0));
https://codereview.chromium.org/18712002/diff/18001/src/code-stubs-hydrogen.cc#newcode782
src/code-stubs-hydrogen.cc:782:
if_number.Return(AddInstruction(new(zone()) HInvokeFunction(
HValue* result = Add<HInvokeFunction>(context(), function, 1);
if_number.Return(result);
https://codereview.chromium.org/18712002/diff/18001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/18712002/diff/18001/src/hydrogen.cc#newcode1986
src/hydrogen.cc:1986: HValue*
HGraphBuilder::LoadJSBuiltin(Builtins::JavaScript builtin,
nit: one space after HValue*, and perhaps call this function
AddLoadJSBuiltin
https://codereview.chromium.org/18712002/diff/18001/src/hydrogen.cc#newcode1989
src/hydrogen.cc:1989: AddInstruction(global_object);
Instead of
HGlobalObject* global_object = new(zone()) HGlobalObject(context);
AddInstruction(global_object);
Just use:
HGlobalObject* global_object = Add<HGlobalOBject>(context);
https://codereview.chromium.org/18712002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
