Feedback addressed, landing.
https://codereview.chromium.org/18331004/diff/2001/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):
https://codereview.chromium.org/18331004/diff/2001/src/code-stubs-hydrogen.cc#newcode810
src/code-stubs-hydrogen.cc:810: Handle<Map>
placeholder_map(Handle<Map>(isolate()->heap()->meta_map()));
On 2013/07/01 12:30:39, Michael Starzinger wrote:
nit: Just use "Handle<Map> placeholder_map =
isolate()->factory()->meta_map();"
instead.
Done.
https://codereview.chromium.org/18331004/diff/2001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/18331004/diff/2001/src/hydrogen-instructions.h#newcode1630
src/hydrogen-instructions.h:1630: HCompareMap(HValue* value, Handle<Map>
map,
On 2013/07/01 12:30:39, Michael Starzinger wrote:
nit: One parameter per line.
Done.
https://codereview.chromium.org/18331004/diff/2001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/18331004/diff/2001/src/hydrogen.cc#newcode1180
src/hydrogen.cc:1180: Handle<Map>(heap->fixed_cow_array_map()));
On 2013/07/01 12:30:39, Michael Starzinger wrote:
nit: Use factory->fixed_cow_array_map() instead.
Done.
https://codereview.chromium.org/18331004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
