Revision: 15510
Author: [email protected]
Date: Fri Jul 5 02:52:11 2013
Log: Keep two empty lines between declarations for cpp files
[email protected]
Review URL: https://codereview.chromium.org/18509003
Patch from Haitao Feng <[email protected]>.
http://code.google.com/p/v8/source/detail?r=15510
Modified:
/branches/bleeding_edge/PRESUBMIT.py
/branches/bleeding_edge/samples/lineprocessor.cc
/branches/bleeding_edge/samples/process.cc
/branches/bleeding_edge/src/api.cc
/branches/bleeding_edge/src/arm/assembler-arm.cc
/branches/bleeding_edge/src/arm/code-stubs-arm.cc
/branches/bleeding_edge/src/arm/codegen-arm.cc
/branches/bleeding_edge/src/arm/disasm-arm.cc
/branches/bleeding_edge/src/arm/macro-assembler-arm.cc
/branches/bleeding_edge/src/arm/simulator-arm.cc
/branches/bleeding_edge/src/assembler.cc
/branches/bleeding_edge/src/atomicops_internals_x86_gcc.cc
/branches/bleeding_edge/src/bignum.cc
/branches/bleeding_edge/src/bootstrapper.cc
/branches/bleeding_edge/src/builtins.cc
/branches/bleeding_edge/src/code-stubs.cc
/branches/bleeding_edge/src/compilation-cache.cc
/branches/bleeding_edge/src/compiler.cc
/branches/bleeding_edge/src/contexts.cc
/branches/bleeding_edge/src/counters.cc
/branches/bleeding_edge/src/cpu-profiler.cc
/branches/bleeding_edge/src/d8.cc
/branches/bleeding_edge/src/dateparser.cc
/branches/bleeding_edge/src/debug.cc
/branches/bleeding_edge/src/disassembler.cc
/branches/bleeding_edge/src/elements-kind.cc
/branches/bleeding_edge/src/execution.cc
/branches/bleeding_edge/src/extensions/i18n/break-iterator.cc
/branches/bleeding_edge/src/extensions/i18n/collator.cc
/branches/bleeding_edge/src/extensions/i18n/i18n-extension.cc
/branches/bleeding_edge/src/extensions/i18n/i18n-utils.cc
/branches/bleeding_edge/src/extensions/i18n/locale.cc
/branches/bleeding_edge/src/factory.cc
/branches/bleeding_edge/src/frames.cc
/branches/bleeding_edge/src/full-codegen.cc
/branches/bleeding_edge/src/gdb-jit.cc
/branches/bleeding_edge/src/global-handles.cc
/branches/bleeding_edge/src/handles.cc
/branches/bleeding_edge/src/heap-profiler.cc
/branches/bleeding_edge/src/heap-snapshot-generator.cc
/branches/bleeding_edge/src/heap.cc
/branches/bleeding_edge/src/hydrogen-gvn.cc
/branches/bleeding_edge/src/hydrogen-instructions.cc
/branches/bleeding_edge/src/hydrogen.cc
/branches/bleeding_edge/src/ia32/assembler-ia32.cc
/branches/bleeding_edge/src/ia32/debug-ia32.cc
/branches/bleeding_edge/src/ia32/disasm-ia32.cc
/branches/bleeding_edge/src/ia32/lithium-codegen-ia32.cc
/branches/bleeding_edge/src/ia32/macro-assembler-ia32.cc
/branches/bleeding_edge/src/ia32/regexp-macro-assembler-ia32.cc
/branches/bleeding_edge/src/incremental-marking.cc
/branches/bleeding_edge/src/isolate.cc
/branches/bleeding_edge/src/lithium.cc
/branches/bleeding_edge/src/liveedit.cc
/branches/bleeding_edge/src/log.cc
/branches/bleeding_edge/src/mips/assembler-mips.cc
/branches/bleeding_edge/src/mips/builtins-mips.cc
/branches/bleeding_edge/src/mips/code-stubs-mips.cc
/branches/bleeding_edge/src/mips/codegen-mips.cc
/branches/bleeding_edge/src/mips/constants-mips.cc
/branches/bleeding_edge/src/mips/lithium-codegen-mips.cc
/branches/bleeding_edge/src/mips/lithium-mips.cc
/branches/bleeding_edge/src/mips/macro-assembler-mips.cc
/branches/bleeding_edge/src/objects-debug.cc
/branches/bleeding_edge/src/objects-printer.cc
/branches/bleeding_edge/src/objects.cc
/branches/bleeding_edge/src/parser.cc
/branches/bleeding_edge/src/platform-cygwin.cc
/branches/bleeding_edge/src/platform-macos.cc
/branches/bleeding_edge/src/platform-openbsd.cc
/branches/bleeding_edge/src/platform-posix.cc
/branches/bleeding_edge/src/platform-win32.cc
/branches/bleeding_edge/src/preparse-data.cc
/branches/bleeding_edge/src/preparser.cc
/branches/bleeding_edge/src/profile-generator.cc
/branches/bleeding_edge/src/runtime.cc
/branches/bleeding_edge/src/sampler.cc
/branches/bleeding_edge/src/scanner-character-streams.cc
/branches/bleeding_edge/src/spaces.cc
/branches/bleeding_edge/src/strtod.cc
/branches/bleeding_edge/src/stub-cache.cc
/branches/bleeding_edge/src/types.cc
/branches/bleeding_edge/src/unicode.cc
/branches/bleeding_edge/src/v8-counters.cc
/branches/bleeding_edge/src/v8.cc
/branches/bleeding_edge/src/v8threads.cc
/branches/bleeding_edge/src/x64/assembler-x64.cc
/branches/bleeding_edge/src/x64/builtins-x64.cc
/branches/bleeding_edge/src/x64/code-stubs-x64.cc
/branches/bleeding_edge/src/x64/disasm-x64.cc
/branches/bleeding_edge/src/x64/lithium-x64.cc
/branches/bleeding_edge/src/x64/macro-assembler-x64.cc
/branches/bleeding_edge/test/cctest/test-accessors.cc
/branches/bleeding_edge/test/cctest/test-api.cc
/branches/bleeding_edge/test/cctest/test-assembler-arm.cc
/branches/bleeding_edge/test/cctest/test-assembler-ia32.cc
/branches/bleeding_edge/test/cctest/test-assembler-x64.cc
/branches/bleeding_edge/test/cctest/test-compare-nil-ic-stub.cc
/branches/bleeding_edge/test/cctest/test-conversions.cc
/branches/bleeding_edge/test/cctest/test-cpu-profiler.cc
/branches/bleeding_edge/test/cctest/test-date.cc
/branches/bleeding_edge/test/cctest/test-debug.cc
/branches/bleeding_edge/test/cctest/test-double.cc
/branches/bleeding_edge/test/cctest/test-heap-profiler.cc
/branches/bleeding_edge/test/cctest/test-list.cc
/branches/bleeding_edge/test/cctest/test-lockers.cc
/branches/bleeding_edge/test/cctest/test-log-stack-tracer.cc
/branches/bleeding_edge/test/cctest/test-log.cc
/branches/bleeding_edge/test/cctest/test-macro-assembler-x64.cc
/branches/bleeding_edge/test/cctest/test-mark-compact.cc
/branches/bleeding_edge/test/cctest/test-object-observe.cc
/branches/bleeding_edge/test/cctest/test-parsing.cc
/branches/bleeding_edge/test/cctest/test-platform-tls.cc
/branches/bleeding_edge/test/cctest/test-platform.cc
/branches/bleeding_edge/test/cctest/test-profile-generator.cc
/branches/bleeding_edge/test/cctest/test-regexp.cc
/branches/bleeding_edge/test/cctest/test-thread-termination.cc
/branches/bleeding_edge/test/cctest/test-threads.cc
/branches/bleeding_edge/test/cctest/test-types.cc
/branches/bleeding_edge/tools/oom_dump/oom_dump.cc
/branches/bleeding_edge/tools/presubmit.py
=======================================
--- /branches/bleeding_edge/PRESUBMIT.py Thu Apr 11 05:41:31 2013
+++ /branches/bleeding_edge/PRESUBMIT.py Fri Jul 5 02:52:11 2013
@@ -44,7 +44,8 @@
results.append(output_api.PresubmitError("C++ lint check failed"))
if not SourceProcessor().Run(input_api.PresubmitLocalPath()):
results.append(output_api.PresubmitError(
- "Copyright header and trailing whitespaces check failed"))
+ "Copyright header, trailing whitespaces and two empty lines " \
+ "between declarations check failed"))
return results
=======================================
--- /branches/bleeding_edge/samples/lineprocessor.cc Wed Jun 5 05:36:33
2013
+++ /branches/bleeding_edge/samples/lineprocessor.cc Fri Jul 5 02:52:11
2013
@@ -321,6 +321,7 @@
return true;
}
+
int main(int argc, char* argv[]) {
int result = RunMain(argc, argv);
@@ -420,6 +421,7 @@
}
args.GetReturnValue().Set(ReadLine());
}
+
v8::Handle<v8::String> ReadLine() {
const int kBufferSize = 1024 + 1;
=======================================
--- /branches/bleeding_edge/samples/process.cc Wed Jun 5 05:36:33 2013
+++ /branches/bleeding_edge/samples/process.cc Fri Jul 5 02:52:11 2013
@@ -54,6 +54,7 @@
virtual const string& UserAgent() = 0;
};
+
/**
* The abstract superclass of http request processors.
*/
@@ -72,6 +73,7 @@
static void Log(const char* event);
};
+
/**
* An http request processor that is scriptable using JavaScript.
*/
@@ -135,6 +137,7 @@
static Persistent<ObjectTemplate> map_template_;
};
+
// -------------------------
// --- P r o c e s s o r ---
// -------------------------
=======================================
--- /branches/bleeding_edge/src/api.cc Thu Jul 4 09:34:07 2013
+++ /branches/bleeding_edge/src/api.cc Fri Jul 5 02:52:11 2013
@@ -297,6 +297,7 @@
static inline bool EmptyCheck(const char* location, const v8::Data* obj) {
return (obj == 0) ? ReportEmptyHandle(location) : false;
}
+
// --- S t a t i c s ---
@@ -321,6 +322,7 @@
ASSERT(isolate == i::Isolate::Current());
return ApiCheck(InitializeHelper(isolate), location, "Error initializing
V8");
}
+
// Some initializing API functions are called early and may be
// called on a thread different from static initializer thread.
@@ -401,6 +403,7 @@
kCompressedStartupDataCount
};
+
int V8::GetCompressedStartupDataCount() {
#ifdef COMPRESS_STARTUP_DATA_BZ2
return kCompressedStartupDataCount;
@@ -669,6 +672,7 @@
void V8::DisposeGlobal(i::Object** obj) {
i::GlobalHandles::Destroy(obj);
}
+
// --- H a n d l e s ---
@@ -4421,6 +4425,7 @@
}
return str->HasOnlyOneByteChars();
}
+
// Helpers for ContainsOnlyOneByteHelper
template<size_t size> struct OneByteMask;
@@ -4435,6 +4440,8 @@
static inline bool Unaligned(const uint16_t* chars) {
return reinterpret_cast<const uintptr_t>(chars) & kAlignmentMask;
}
+
+
static inline const uint16_t* Align(const uint16_t* chars) {
return reinterpret_cast<uint16_t*>(
reinterpret_cast<uintptr_t>(chars) & ~kAlignmentMask);
@@ -6280,6 +6287,7 @@
bool v8::ArrayBuffer::IsExternal() const {
return Utils::OpenHandle(this)->is_external();
}
+
v8::ArrayBuffer::Contents v8::ArrayBuffer::Externalize() {
i::Handle<i::JSArrayBuffer> obj = Utils::OpenHandle(this);
@@ -6580,6 +6588,7 @@
v8::AssertNoGCScope::AssertNoGCScope(v8::Isolate* isolate) {
disallow_heap_allocation_ = new i::DisallowHeapAllocation();
}
+
v8::AssertNoGCScope::~AssertNoGCScope() {
delete
static_cast<i::DisallowHeapAllocation*>(disallow_heap_allocation_);
@@ -6643,6 +6652,7 @@
if (IsDeadCheck(isolate, "v8::V8::SetCounterFunction()")) return;
isolate->stats_table()->SetCounterFunction(callback);
}
+
void V8::SetCreateHistogramFunction(CreateHistogramCallback callback) {
i::Isolate* isolate = EnterIsolateIfNeeded();
@@ -6651,6 +6661,7 @@
isolate->InitializeLoggingAndCounters();
isolate->counters()->ResetHistograms();
}
+
void V8::SetAddHistogramSampleFunction(AddHistogramSampleCallback
callback) {
i::Isolate* isolate = EnterIsolateIfNeeded();
@@ -6998,6 +7009,7 @@
String::Value::~Value() {
i::DeleteArray(str_);
}
+
Local<Value> Exception::RangeError(v8::Handle<v8::String> raw_message) {
i::Isolate* isolate = i::Isolate::Current();
@@ -7014,6 +7026,7 @@
i::Handle<i::Object> result(error, isolate);
return Utils::ToLocal(result);
}
+
Local<Value> Exception::ReferenceError(v8::Handle<v8::String> raw_message)
{
i::Isolate* isolate = i::Isolate::Current();
@@ -7031,6 +7044,7 @@
i::Handle<i::Object> result(error, isolate);
return Utils::ToLocal(result);
}
+
Local<Value> Exception::SyntaxError(v8::Handle<v8::String> raw_message) {
i::Isolate* isolate = i::Isolate::Current();
@@ -7047,6 +7061,7 @@
i::Handle<i::Object> result(error, isolate);
return Utils::ToLocal(result);
}
+
Local<Value> Exception::TypeError(v8::Handle<v8::String> raw_message) {
i::Isolate* isolate = i::Isolate::Current();
@@ -7063,6 +7078,7 @@
i::Handle<i::Object> result(error, isolate);
return Utils::ToLocal(result);
}
+
Local<Value> Exception::Error(v8::Handle<v8::String> raw_message) {
i::Isolate* isolate = i::Isolate::Current();
@@ -7807,6 +7823,7 @@
void Testing::SetStressRunType(Testing::StressType type) {
internal::Testing::set_stress_type(type);
}
+
int Testing::GetStressRuns() {
if (internal::FLAG_stress_runs != 0) return internal::FLAG_stress_runs;
=======================================
--- /branches/bleeding_edge/src/arm/assembler-arm.cc Fri Jun 28 08:34:48
2013
+++ /branches/bleeding_edge/src/arm/assembler-arm.cc Fri Jul 5 02:52:11
2013
@@ -55,6 +55,7 @@
ASSERT(CpuFeatures::initialized_);
return ExternalReference(&CpuFeatures::supported_);
}
+
// Get the CPU features enabled by the build. For cross compilation the
// preprocessor symbols CAN_USE_ARMV7_INSTRUCTIONS and
CAN_USE_VFP3_INSTRUCTIONS
@@ -355,6 +356,7 @@
offset_ = offset;
am_ = am;
}
+
MemOperand::MemOperand(Register rn, Register rm, AddrMode am) {
rn_ = rn;
@@ -676,6 +678,7 @@
ASSERT(IsCmpImmediate(instr));
return instr & kOff12Mask;
}
+
// Labels refer to positions in the (to be) generated code.
// There are bound, linked, and unused labels.
@@ -1639,6 +1642,7 @@
ASSERT(IsEnabled(ARMv7));
addrmod3(cond | B7 | B6 | B5 | B4, src1, dst);
}
+
// Load/Store multiple instructions.
void Assembler::ldm(BlockAddrMode am,
@@ -2073,6 +2077,7 @@
emit(cond | B27 | B26 | am | d*B22 | base.code()*B16 | sd*B12 |
0xA*B8 | count);
}
+
static void DoubleAsTwoUInt32(double d, uint32_t* lo, uint32_t* hi) {
uint64_t i;
@@ -2081,6 +2086,7 @@
*lo = i & 0xffffffff;
*hi = i >> 32;
}
+
// Only works for little endian floating point formats.
// We don't support VFP on the mixed endian floating point platform.
@@ -2773,6 +2779,7 @@
RecordRelocInfo(RelocInfo::CONST_POOL, static_cast<intptr_t>(size));
#endif
}
+
void Assembler::GrowBuffer() {
if (!own_buffer_) FATAL("external code buffer is too small");
@@ -2893,6 +2900,7 @@
}
}
}
+
void Assembler::RecordRelocInfo(double data) {
// We do not try to reuse pool constants.
=======================================
--- /branches/bleeding_edge/src/arm/code-stubs-arm.cc Fri Jul 5 02:26:22
2013
+++ /branches/bleeding_edge/src/arm/code-stubs-arm.cc Fri Jul 5 02:52:11
2013
@@ -6452,6 +6452,7 @@
RememberedSetAction action;
};
+
#define REG(Name) { kRegister_ ## Name ## _Code }
static const AheadOfTimeWriteBarrierStubList kAheadOfTime[] = {
=======================================
--- /branches/bleeding_edge/src/arm/codegen-arm.cc Fri Jun 28 08:34:48 2013
+++ /branches/bleeding_edge/src/arm/codegen-arm.cc Fri Jul 5 02:52:11 2013
@@ -119,6 +119,7 @@
UnaryMathFunction CreateSqrtFunction() {
return &sqrt;
}
+
//
-------------------------------------------------------------------------
// Platform-specific RuntimeCallHelper functions.
=======================================
--- /branches/bleeding_edge/src/arm/disasm-arm.cc Fri Jun 28 08:34:48 2013
+++ /branches/bleeding_edge/src/arm/disasm-arm.cc Fri Jul 5 02:52:11 2013
@@ -186,11 +186,13 @@
void Decoder::PrintRegister(int reg) {
Print(converter_.NameOfCPURegister(reg));
}
+
// Print the VFP S register name according to the active name converter.
void Decoder::PrintSRegister(int reg) {
Print(VFPRegisters::Name(reg, false));
}
+
// Print the VFP D register name according to the active name converter.
void Decoder::PrintDRegister(int reg) {
=======================================
--- /branches/bleeding_edge/src/arm/macro-assembler-arm.cc Wed Jul 3
08:39:18 2013
+++ /branches/bleeding_edge/src/arm/macro-assembler-arm.cc Fri Jul 5
02:52:11 2013
@@ -1032,6 +1032,7 @@
add(sp, sp, Operand(argument_count, LSL, kPointerSizeLog2));
}
}
+
void MacroAssembler::GetCFunctionDoubleResult(const DwVfpRegister dst) {
if (use_eabi_hardfloat()) {
=======================================
--- /branches/bleeding_edge/src/arm/simulator-arm.cc Fri Jun 28 08:34:48
2013
+++ /branches/bleeding_edge/src/arm/simulator-arm.cc Fri Jul 5 02:52:11
2013
@@ -1025,6 +1025,7 @@
registers_[3] = 0x50Bad4U;
registers_[12] = 0x50Bad4U;
}
+
// Some Operating Systems allow unaligned access on ARMv7 targets. We
// assume that unaligned accesses are not allowed unless the v8 build
system
@@ -1524,6 +1525,7 @@
set_register(rn, rn_val);
}
}
+
// Addressing Mode 4 - Load and Store Multiple
void Simulator::HandleRList(Instruction* instr, bool load) {
@@ -1953,6 +1955,7 @@
return (FPSCR_default_NaN_mode_ && std::isnan(value)) ?
FixedDoubleArray::canonical_not_the_hole_nan_as_double() : value;
}
+
// Stop helper functions.
bool Simulator::isStopInstruction(Instruction* instr) {
=======================================
--- /branches/bleeding_edge/src/assembler.cc Fri Jun 28 08:34:48 2013
+++ /branches/bleeding_edge/src/assembler.cc Fri Jul 5 02:52:11 2013
@@ -380,6 +380,7 @@
data_delta = data_delta >> kBitsPerByte;
}
}
+
void RelocInfoWriter::WriteExtraTaggedConstPoolData(int data) {
WriteExtraTag(kConstPoolExtraTag, kConstPoolTag);
@@ -389,6 +390,7 @@
data = data >> kBitsPerByte;
}
}
+
void RelocInfoWriter::WriteExtraTaggedData(intptr_t data_delta, int
top_tag) {
WriteExtraTag(kDataJumpExtraTag, top_tag);
@@ -1321,6 +1323,7 @@
#endif
return ExternalReference(Redirect(isolate, function));
}
+
ExternalReference ExternalReference::re_grow_stack(Isolate* isolate) {
return ExternalReference(
@@ -1333,6 +1336,7 @@
isolate,
FUNCTION_ADDR(NativeRegExpMacroAssembler::CaseInsensitiveCompareUC16)));
}
+
ExternalReference ExternalReference::re_word_character_map() {
return ExternalReference(
=======================================
--- /branches/bleeding_edge/src/atomicops_internals_x86_gcc.cc Tue Apr 16
05:30:51 2013
+++ /branches/bleeding_edge/src/atomicops_internals_x86_gcc.cc Fri Jul 5
02:52:11 2013
@@ -124,6 +124,7 @@
}
};
+
// A global to get use initialized on startup via static initialization :/
AtomicOpsx86Initializer g_initer;
=======================================
--- /branches/bleeding_edge/src/bignum.cc Mon Apr 8 08:13:57 2013
+++ /branches/bleeding_edge/src/bignum.cc Fri Jul 5 02:52:11 2013
@@ -44,6 +44,7 @@
static int BitSize(S value) {
return 8 * sizeof(value);
}
+
// Guaranteed to lie in one Bigit.
void Bignum::AssignUInt16(uint16_t value) {
=======================================
--- /branches/bleeding_edge/src/bootstrapper.cc Wed Jul 3 04:22:29 2013
+++ /branches/bleeding_edge/src/bootstrapper.cc Fri Jul 5 02:52:11 2013
@@ -1585,6 +1585,7 @@
INSTALL_NATIVE(JSFunction, "ToCompletePropertyDescriptor",
to_complete_property_descriptor);
}
+
void Genesis::InstallExperimentalNativeFunctions() {
if (FLAG_harmony_proxies) {
@@ -2238,10 +2239,12 @@
}
#endif
}
+
static uint32_t Hash(RegisteredExtension* extension) {
return v8::internal::ComputePointerHash(extension);
}
+
static bool MatchRegisteredExtensions(void* key1, void* key2) {
return key1 == key2;
=======================================
--- /branches/bleeding_edge/src/builtins.cc Wed Jul 3 08:39:18 2013
+++ /branches/bleeding_edge/src/builtins.cc Fri Jul 5 02:52:11 2013
@@ -181,6 +181,7 @@
ASSERT_EQ(result, reference_result);
return result;
}
+
//
----------------------------------------------------------------------------
@@ -1152,6 +1153,7 @@
return isolate->Throw(*isolate->factory()->NewTypeError(
"strict_poison_pill", HandleVector<Object>(NULL, 0)));
}
+
//
-----------------------------------------------------------------------------
//
@@ -1431,14 +1433,17 @@
static void Generate_KeyedLoadIC_PreMonomorphic(MacroAssembler* masm) {
KeyedLoadIC::GeneratePreMonomorphic(masm);
}
+
static void Generate_KeyedLoadIC_IndexedInterceptor(MacroAssembler* masm) {
KeyedLoadIC::GenerateIndexedInterceptor(masm);
}
+
static void Generate_KeyedLoadIC_NonStrictArguments(MacroAssembler* masm) {
KeyedLoadIC::GenerateNonStrictArguments(masm);
}
+
static void Generate_StoreIC_Slow(MacroAssembler* masm) {
StoreIC::GenerateSlow(masm);
@@ -1538,14 +1543,17 @@
static void Generate_KeyedStoreIC_Initialize_Strict(MacroAssembler* masm) {
KeyedStoreIC::GenerateInitialize(masm);
}
+
static void Generate_KeyedStoreIC_NonStrictArguments(MacroAssembler* masm)
{
KeyedStoreIC::GenerateNonStrictArguments(masm);
}
+
static void Generate_TransitionElementsSmiToDouble(MacroAssembler* masm) {
KeyedStoreIC::GenerateTransitionElementsSmiToDouble(masm);
}
+
static void Generate_TransitionElementsDoubleToObject(MacroAssembler*
masm) {
KeyedStoreIC::GenerateTransitionElementsDoubleToObject(masm);
@@ -1715,6 +1723,7 @@
#undef DEF_FUNCTION_PTR_C
#undef DEF_FUNCTION_PTR_A
}
+
void Builtins::SetUp(bool create_heap_objects) {
ASSERT(!initialized_);
=======================================
--- /branches/bleeding_edge/src/code-stubs.cc Fri Jul 5 02:26:22 2013
+++ /branches/bleeding_edge/src/code-stubs.cc Fri Jul 5 02:52:11 2013
@@ -183,6 +183,7 @@
return NULL;
}
}
+
void CodeStub::PrintBaseName(StringStream* stream) {
stream->Add("%s", MajorName(MajorKey(), false));
@@ -562,12 +563,14 @@
stream.OutputToStdOut();
#endif
}
+
void CompareNilICStub::PrintBaseName(StringStream* stream) {
CodeStub::PrintBaseName(stream);
stream->Add((nil_value_ == kNullValue) ? "(NullValue)":
"(UndefinedValue)");
}
+
void CompareNilICStub::PrintState(StringStream* stream) {
state_.Print(stream);
=======================================
--- /branches/bleeding_edge/src/compilation-cache.cc Tue Mar 12 00:06:36
2013
+++ /branches/bleeding_edge/src/compilation-cache.cc Fri Jul 5 02:52:11
2013
@@ -85,6 +85,7 @@
}
return result;
}
+
void CompilationSubCache::Age() {
// Age the generations implicitly killing off the oldest.
=======================================
--- /branches/bleeding_edge/src/compiler.cc Wed Jul 3 08:39:18 2013
+++ /branches/bleeding_edge/src/compiler.cc Fri Jul 5 02:52:11 2013
@@ -448,6 +448,7 @@
return SetLastStatus(SUCCEEDED);
}
+
OptimizingCompiler::Status OptimizingCompiler::OptimizeGraph() {
DisallowHeapAllocation no_allocation;
=======================================
--- /branches/bleeding_edge/src/contexts.cc Mon Feb 25 06:46:09 2013
+++ /branches/bleeding_edge/src/contexts.cc Fri Jul 5 02:52:11 2013
@@ -87,6 +87,7 @@
JSObject* Context::global_proxy() {
return native_context()->global_proxy_object();
}
+
void Context::set_global_proxy(JSObject* object) {
native_context()->set_global_proxy_object(object);
=======================================
--- /branches/bleeding_edge/src/counters.cc Wed Apr 24 06:52:26 2013
+++ /branches/bleeding_edge/src/counters.cc Fri Jul 5 02:52:11 2013
@@ -55,6 +55,7 @@
return isolate()->stats_table()->
CreateHistogram(name_, min_, max_, num_buckets_);
}
+
// Start the timer.
void HistogramTimer::Start() {
@@ -66,6 +67,7 @@
LOG(isolate(), TimerEvent(Logger::START, name()));
}
}
+
// Stop the timer and record the results.
void HistogramTimer::Stop() {
=======================================
--- /branches/bleeding_edge/src/cpu-profiler.cc Tue Jul 2 08:44:30 2013
+++ /branches/bleeding_edge/src/cpu-profiler.cc Fri Jul 5 02:52:11 2013
@@ -422,6 +422,7 @@
delete profiles_;
profiles_ = new CpuProfilesCollection();
}
+
void CpuProfiler::StartProfiling(const char* title, bool record_samples) {
if (profiles_->StartProfiling(title, next_profile_uid_++,
record_samples)) {
=======================================
--- /branches/bleeding_edge/src/d8.cc Mon Jun 24 06:15:07 2013
+++ /branches/bleeding_edge/src/d8.cc Fri Jul 5 02:52:11 2013
@@ -1086,6 +1086,7 @@
delete[] data;
array_buffer->Dispose();
}
+
void Shell::ReadBuffer(const v8::FunctionCallbackInfo<v8::Value>& args) {
ASSERT(sizeof(char) == sizeof(uint8_t)); // NOLINT
=======================================
--- /branches/bleeding_edge/src/dateparser.cc Fri Jul 1 04:41:45 2011
+++ /branches/bleeding_edge/src/dateparser.cc Fri Jul 5 02:52:11 2013
@@ -111,6 +111,7 @@
output->set(MILLISECOND, Smi::FromInt(millisecond));
return true;
}
+
bool DateParser::TimeZoneComposer::Write(FixedArray* output) {
if (sign_ != kNone) {
=======================================
--- /branches/bleeding_edge/src/debug.cc Mon Jul 1 06:44:10 2013
+++ /branches/bleeding_edge/src/debug.cc Fri Jul 5 02:52:11 2013
@@ -1810,6 +1810,7 @@
// Clear multiple step counter.
thread_local_.step_count_ = 0;
}
+
// Clears all the one-shot break points that are currently set. Normally
this
// function is called each time a break point is hit as one shot break
points
=======================================
--- /branches/bleeding_edge/src/disassembler.cc Mon Jun 3 08:32:22 2013
+++ /branches/bleeding_edge/src/disassembler.cc Fri Jul 5 02:52:11 2013
@@ -360,6 +360,8 @@
int Disassembler::Decode(Isolate* isolate, FILE* f, byte* begin, byte*
end) {
return 0;
}
+
+
void Disassembler::Decode(FILE* f, Code* code) {}
#endif // ENABLE_DISASSEMBLER
=======================================
--- /branches/bleeding_edge/src/elements-kind.cc Fri Nov 2 02:18:53 2012
+++ /branches/bleeding_edge/src/elements-kind.cc Fri Jul 5 02:52:11 2013
@@ -82,6 +82,7 @@
sequence_number < kFastElementsKindCount);
return fast_elements_kind_sequence.Get()[sequence_number];
}
+
int GetSequenceIndexFromFastElementsKind(ElementsKind elements_kind) {
for (int i = 0; i < kFastElementsKindCount; ++i) {
=======================================
--- /branches/bleeding_edge/src/execution.cc Tue Jun 4 03:30:05 2013
+++ /branches/bleeding_edge/src/execution.cc Fri Jul 5 02:52:11 2013
@@ -864,6 +864,7 @@
// Return to continue execution.
return isolate->heap()->undefined_value();
}
+
void Execution::ProcessDebugMessages(bool debug_command_only) {
Isolate* isolate = Isolate::Current();
=======================================
--- /branches/bleeding_edge/src/extensions/i18n/break-iterator.cc Wed Jul
3 04:22:29 2013
+++ /branches/bleeding_edge/src/extensions/i18n/break-iterator.cc Fri Jul
5 02:52:11 2013
@@ -81,6 +81,7 @@
// Then dispose of the persistent handle to JS object.
object->Dispose(isolate);
}
+
// Throws a JavaScript exception.
static v8::Handle<v8::Value> ThrowUnexpectedObjectError() {
@@ -89,6 +90,7 @@
v8::String::New("BreakIterator method called on an object "
"that is not a BreakIterator.")));
}
+
// Deletes the old value and sets the adopted text in corresponding
// JavaScript object.
=======================================
--- /branches/bleeding_edge/src/extensions/i18n/collator.cc Wed Jul 3
04:22:29 2013
+++ /branches/bleeding_edge/src/extensions/i18n/collator.cc Fri Jul 5
02:52:11 2013
@@ -75,6 +75,7 @@
// Then dispose of the persistent handle to JS object.
object->Dispose(isolate);
}
+
// Throws a JavaScript exception.
static v8::Handle<v8::Value> ThrowUnexpectedObjectError() {
@@ -83,11 +84,13 @@
v8::String::New("Collator method called on an object "
"that is not a Collator.")));
}
+
// When there's an ICU error, throw a JavaScript error with |message|.
static v8::Handle<v8::Value> ThrowExceptionForICUError(const char*
message) {
return
v8::ThrowException(v8::Exception::Error(v8::String::New(message)));
}
+
// static
void Collator::JSInternalCompare(
=======================================
--- /branches/bleeding_edge/src/extensions/i18n/i18n-extension.cc Wed Jul
3 04:22:29 2013
+++ /branches/bleeding_edge/src/extensions/i18n/i18n-extension.cc Fri Jul
5 02:52:11 2013
@@ -107,6 +107,7 @@
return v8::Handle<v8::FunctionTemplate>();
}
+
void Extension::Register() {
static Extension i18n_extension;
=======================================
--- /branches/bleeding_edge/src/extensions/i18n/i18n-utils.cc Wed Jul 3
04:22:29 2013
+++ /branches/bleeding_edge/src/extensions/i18n/i18n-utils.cc Fri Jul 5
02:52:11 2013
@@ -41,6 +41,7 @@
strncpy(dest, src, length);
dest[length - 1] = '\0';
}
+
// static
bool Utils::V8StringToUnicodeString(const v8::Handle<v8::Value>& input,
@@ -53,6 +54,7 @@
return true;
}
+
// static
bool Utils::ExtractStringSetting(const v8::Handle<v8::Object>& settings,
@@ -73,6 +75,7 @@
}
return false;
}
+
// static
bool Utils::ExtractIntegerSetting(const v8::Handle<v8::Object>& settings,
@@ -94,6 +97,7 @@
}
return false;
}
+
// static
bool Utils::ExtractBooleanSetting(const v8::Handle<v8::Object>& settings,
@@ -115,6 +119,7 @@
}
return false;
}
+
// static
void Utils::AsciiToUChar(const char* source,
@@ -134,6 +139,7 @@
target[length - 1] = 0x0u;
}
+
// static
// Chrome Linux doesn't like static initializers in class, so we create
@@ -152,6 +158,7 @@
return v8::Local<v8::ObjectTemplate>::New(isolate, icu_template);
}
+
// static
// Chrome Linux doesn't like static initializers in class, so we create
=======================================
--- /branches/bleeding_edge/src/extensions/i18n/locale.cc Wed Jul 3
04:22:29 2013
+++ /branches/bleeding_edge/src/extensions/i18n/locale.cc Fri Jul 5
02:52:11 2013
@@ -81,6 +81,7 @@
args.GetReturnValue().Set(v8::String::New(result));
}
+
void JSAvailableLocalesOf(const v8::FunctionCallbackInfo<v8::Value>& args)
{
// Expect service name which is a string.
@@ -130,6 +131,7 @@
args.GetReturnValue().Set(locales);
}
+
void JSGetDefaultICULocale(const v8::FunctionCallbackInfo<v8::Value>&
args) {
icu::Locale default_locale;
@@ -146,6 +148,7 @@
args.GetReturnValue().Set(v8::String::New("und"));
}
+
void JSGetLanguageTagVariants(const v8::FunctionCallbackInfo<v8::Value>&
args) {
v8::TryCatch try_catch;
=======================================
--- /branches/bleeding_edge/src/factory.cc Tue Jul 2 08:30:33 2013
+++ /branches/bleeding_edge/src/factory.cc Fri Jul 5 02:52:11 2013
@@ -177,6 +177,7 @@
isolate()->heap()->InternalizeUtf8String(string),
String);
}
+
// Internalized strings are created in the old generation (data space).
Handle<String> Factory::InternalizeString(Handle<String> string) {
@@ -184,6 +185,7 @@
isolate()->heap()->InternalizeString(*string),
String);
}
+
Handle<String> Factory::InternalizeOneByteString(Vector<const uint8_t>
string) {
CALL_HEAP_FUNCTION(isolate(),
@@ -1234,6 +1236,7 @@
*stack_frames),
JSMessageObject);
}
+
Handle<SharedFunctionInfo> Factory::NewSharedFunctionInfo(Handle<String>
name) {
CALL_HEAP_FUNCTION(isolate(),
=======================================
--- /branches/bleeding_edge/src/frames.cc Wed Jul 3 09:20:59 2013
+++ /branches/bleeding_edge/src/frames.cc Fri Jul 5 02:52:11 2013
@@ -201,6 +201,7 @@
if (IsValidFrame()) return;
}
}
+
bool StackTraceFrameIterator::IsValidFrame() {
if (!frame()->function()->IsJSFunction()) return false;
@@ -1567,6 +1568,7 @@
ASSERT(i == kNumJSCallerSaved);
}
+
int JSCallerSavedCode(int n) {
ASSERT(0 <= n && n < kNumJSCallerSaved);
@@ -1599,6 +1601,7 @@
#undef FRAME_TYPE_CASE
return NULL;
}
+
Vector<StackFrame*> CreateStackMap(Isolate* isolate, Zone* zone) {
ZoneList<StackFrame*> list(10, zone);
=======================================
--- /branches/bleeding_edge/src/full-codegen.cc Fri Jun 28 08:48:38 2013
+++ /branches/bleeding_edge/src/full-codegen.cc Fri Jul 5 02:52:11 2013
@@ -75,12 +75,15 @@
void BreakableStatementChecker::VisitModuleLiteral(ModuleLiteral* module) {
}
+
void BreakableStatementChecker::VisitModuleVariable(ModuleVariable*
module) {
}
+
void BreakableStatementChecker::VisitModulePath(ModulePath* module) {
}
+
void BreakableStatementChecker::VisitModuleUrl(ModuleUrl* module) {
}
=======================================
--- /branches/bleeding_edge/src/gdb-jit.cc Wed Jul 3 08:29:59 2013
+++ /branches/bleeding_edge/src/gdb-jit.cc Fri Jul 5 02:52:11 2013
@@ -2014,6 +2014,7 @@
AddCode("", *code, GDBJITInterface::FUNCTION, *script, info);
}
}
+
static void AddUnwindInfo(CodeDescription* desc) {
#if V8_TARGET_ARCH_X64
=======================================
--- /branches/bleeding_edge/src/global-handles.cc Mon Jun 3 03:02:02 2013
+++ /branches/bleeding_edge/src/global-handles.cc Fri Jul 5 02:52:11 2013
@@ -798,6 +798,7 @@
PrintF(" # free = %d\n", destroyed);
PrintF(" # total = %d\n", total);
}
+
void GlobalHandles::Print() {
PrintF("Global handles:\n");
=======================================
--- /branches/bleeding_edge/src/handles.cc Tue Jul 2 08:32:46 2013
+++ /branches/bleeding_edge/src/handles.cc Fri Jul 5 02:52:11 2013
@@ -498,6 +498,7 @@
}
return right + script->line_offset()->value();
}
+
// Convert code position into column number.
int GetScriptColumnNumber(Handle<Script> script, int code_pos) {
@@ -512,6 +513,7 @@
Smi::cast(line_ends_array->get(line_number - 1))->value();
return code_pos - (prev_line_end_pos + 1);
}
+
int GetScriptLineNumberSafe(Handle<Script> script, int code_pos) {
DisallowHeapAllocation no_allocation;
=======================================
--- /branches/bleeding_edge/src/heap-profiler.cc Thu Jul 4 09:34:07 2013
+++ /branches/bleeding_edge/src/heap-profiler.cc Fri Jul 5 02:52:11 2013
@@ -93,6 +93,7 @@
v8::HeapProfiler::ObjectNameResolver* resolver) {
return TakeSnapshot(snapshots_->names()->GetName(name), control,
resolver);
}
+
void HeapProfiler::StartHeapObjectsTracking() {
snapshots_->StartHeapObjectsTracking();
=======================================
--- /branches/bleeding_edge/src/heap-snapshot-generator.cc Thu Jul 4
09:34:07 2013
+++ /branches/bleeding_edge/src/heap-snapshot-generator.cc Fri Jul 5
02:52:11 2013
@@ -458,6 +458,7 @@
void HeapObjectsMap::StopHeapObjectsTracking() {
time_intervals_.Clear();
}
+
void HeapObjectsMap::UpdateHeapObjectsMap() {
HEAP->CollectAllGarbage(Heap::kMakeHeapIterableMask,
@@ -1962,6 +1963,7 @@
isolate->global_handles()->IterateAllRootsWithClassIds(&extractor);
embedder_queried_ = true;
}
+
void NativeObjectsExplorer::FillImplicitReferences() {
Isolate* isolate = Isolate::Current();
@@ -2587,6 +2589,7 @@
w->AddCharacter(hex_chars[(u >> 4) & 0xf]);
w->AddCharacter(hex_chars[u & 0xf]);
}
+
void HeapSnapshotJSONSerializer::SerializeString(const unsigned char* s) {
writer_->AddCharacter('\n');
=======================================
--- /branches/bleeding_edge/src/heap.cc Wed Jul 3 08:39:18 2013
+++ /branches/bleeding_edge/src/heap.cc Fri Jul 5 02:52:11 2013
@@ -3500,6 +3500,7 @@
return kUndefinedValueRootIndex;
}
}
+
ExternalArray* Heap::EmptyExternalArrayForMap(Map* map) {
return ExternalArray::cast(
@@ -5230,6 +5231,7 @@
ASSERT(s->length() == len);
String::WriteToFlat(s, chars, 0, len);
}
+
static inline void WriteTwoByteData(String* s, uint16_t* chars, int len) {
ASSERT(s->length() == len);
@@ -5414,6 +5416,7 @@
reinterpret_cast<FixedArray*>(result)->set_length(0);
return result;
}
+
MaybeObject* Heap::AllocateEmptyExternalArray(ExternalArrayType
array_type) {
return AllocateExternalArray(0, array_type, NULL, TENURED);
@@ -6750,6 +6753,7 @@
NewSpaceScavenger::Initialize();
MarkCompactCollector::Initialize();
}
+
bool Heap::SetUp() {
#ifdef DEBUG
@@ -6860,6 +6864,7 @@
return true;
}
+
bool Heap::CreateHeapObjects() {
// Create initial maps.
@@ -7026,6 +7031,7 @@
}
};
+
void Heap::PrintHandles() {
PrintF("Handles:\n");
PrintHandleVisitor v;
=======================================
--- /branches/bleeding_edge/src/hydrogen-gvn.cc Fri Jun 28 09:31:11 2013
+++ /branches/bleeding_edge/src/hydrogen-gvn.cc Fri Jul 5 02:52:11 2013
@@ -122,6 +122,7 @@
OS::VPrint(msg, arguments);
va_end(arguments);
}
+
// Wrap TraceGVN in macros to avoid the expense of evaluating its
arguments when
// --trace-gvn is off.
@@ -338,6 +339,7 @@
}
return *this;
}
+
void HSideEffectMap::Kill(GVNFlagSet flags) {
for (int i = 0; i < kNumberOfTrackedSideEffects; i++) {
@@ -748,6 +750,7 @@
int length_;
};
+
// This is a recursive traversal of the dominator tree but it has been
turned
// into a loop to avoid stack overflows.
// The logical "stack frames" of the recursion are kept in a list of
=======================================
--- /branches/bleeding_edge/src/hydrogen-instructions.cc Fri Jul 5
02:26:22 2013
+++ /branches/bleeding_edge/src/hydrogen-instructions.cc Fri Jul 5
02:52:11 2013
@@ -1700,6 +1700,7 @@
UNREACHABLE();
return "";
}
+
void HCheckInstanceType::PrintDataTo(StringStream* stream) {
stream->Add("%s ", GetCheckName());
=======================================
--- /branches/bleeding_edge/src/hydrogen.cc Fri Jul 5 02:26:22 2013
+++ /branches/bleeding_edge/src/hydrogen.cc Fri Jul 5 02:52:11 2013
@@ -2110,6 +2110,7 @@
}
}
}
+
// Block ordering was implemented with two mutually recursive methods,
// HGraph::Postorder and HGraph::PostorderLoopBlocks.
@@ -8641,6 +8642,7 @@
HInstruction* checked_index = Add<HBoundsCheck>(index, length);
return new(zone()) HStringCharCodeAt(context, string, checked_index);
}
+
// Checks if the given shift amounts have form: (sa) and (32 - sa).
static bool ShiftAmountsAllowReplaceByRotate(HValue* sa,
@@ -9534,6 +9536,7 @@
}
}
}
+
void HOptimizedGraphBuilder::VisitThisFunction(ThisFunction* expr) {
ASSERT(!HasStackOverflow());
=======================================
--- /branches/bleeding_edge/src/ia32/assembler-ia32.cc Fri Jun 28 08:34:48
2013
+++ /branches/bleeding_edge/src/ia32/assembler-ia32.cc Fri Jul 5 02:52:11
2013
@@ -1054,6 +1054,7 @@
EMIT(imm8);
}
}
+
void Assembler::ror(Register dst, uint8_t imm8) {
EnsureSpace ensure_space(this);
@@ -1067,6 +1068,7 @@
EMIT(imm8);
}
}
+
void Assembler::ror_cl(Register dst) {
EnsureSpace ensure_space(this);
@@ -2136,6 +2138,7 @@
// Mask precision exeption.
EMIT(static_cast<byte>(mode) | 0x8);
}
+
void Assembler::movmskpd(Register dst, XMMRegister src) {
ASSERT(IsEnabled(SSE2));
=======================================
--- /branches/bleeding_edge/src/ia32/debug-ia32.cc Fri Jun 28 08:34:48 2013
+++ /branches/bleeding_edge/src/ia32/debug-ia32.cc Fri Jul 5 02:52:11 2013
@@ -90,6 +90,7 @@
ASSERT(IsDebugBreakSlot());
rinfo()->PatchCode(original_rinfo()->pc(),
Assembler::kDebugBreakSlotLength);
}
+
// All debug break stubs support padding for LiveEdit.
const bool Debug::FramePaddingLayout::kIsSupported = true;
=======================================
--- /branches/bleeding_edge/src/ia32/disasm-ia32.cc Fri Jun 28 08:34:48 2013
+++ /branches/bleeding_edge/src/ia32/disasm-ia32.cc Fri Jul 5 02:52:11 2013
@@ -574,6 +574,7 @@
return 2;
}
}
+
int DisassemblerIA32::D1D3C1Instruction(byte* data) {
byte op = *data;
=======================================
--- /branches/bleeding_edge/src/ia32/lithium-codegen-ia32.cc Fri Jul 5
02:26:22 2013
+++ /branches/bleeding_edge/src/ia32/lithium-codegen-ia32.cc Fri Jul 5
02:52:11 2013
@@ -3805,6 +3805,7 @@
__ bind(&done);
}
}
+
void LCodeGen::DoMathRound(LMathRound* instr) {
CpuFeatureScope scope(masm(), SSE2);
=======================================
--- /branches/bleeding_edge/src/ia32/macro-assembler-ia32.cc Wed Jul 3
08:39:18 2013
+++ /branches/bleeding_edge/src/ia32/macro-assembler-ia32.cc Fri Jul 5
02:52:11 2013
@@ -841,6 +841,7 @@
LeaveExitFrameEpilogue();
}
+
void MacroAssembler::LeaveExitFrameEpilogue() {
// Restore current context from top and clear it in debug mode.
=======================================
--- /branches/bleeding_edge/src/ia32/regexp-macro-assembler-ia32.cc Wed
Jul 3 08:39:18 2013
+++ /branches/bleeding_edge/src/ia32/regexp-macro-assembler-ia32.cc Fri
Jul 5 02:52:11 2013
@@ -1029,6 +1029,7 @@
LoadCurrentCharacterUnchecked(-1, 1);
__ bind(&after_position);
}
+
void RegExpMacroAssemblerIA32::SetRegister(int register_index, int to) {
ASSERT(register_index >= num_saved_registers_); // Reserved for
positions!
=======================================
***Additional files exist in this changeset.***
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
