On 2013/07/04 16:28:42, Yury Semikhatsky wrote:
On 2013/07/04 14:59:19, Yang wrote:
> On 2013/07/04 14:14:42, loislo wrote:
> > lgtm
>
> As far as I can see, the counter's sole purpose is for the tests. Would
it
be
> possible to do the counting in the tests, even if it's more expensive?
I see two options:
1) Have a flag on the sampler whether to count samples and turn it on
only in
tests.
2) Make Sampler dispatch tick event notification to its listeners and
implement
the counter in the tests.
Do any of them make sense to you?
Note that this code has always been there just for the testing purpose
(though
it is unused at the moment).
Added Sampler::is_counting_samples_ flag which is true only in tests. PTAL
https://codereview.chromium.org/18418004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
