Reviewers: Yury Semikhatsky, alph, Yang, Jakob,
Description:
CPUProfiler: Improve line numbers support in profiler.
1) report line number even if a script has no resource_name (evals);
a) do that for already compiled functions in log.cc;
b) do that for fresh evals in compiler.cc;
2) Implement the test for LineNumbers and make it fast and stable,
otherwise we
have to wait for tick samples;
a) introduce processor Start function and process CodeEvents for already
compiled functions synchronously;
b) move processor_->Join() call into Processor::Stop method;
c) Process all the CodeEvents even if we are stopping Processor thread;
d) make getters for generator and processor;
3) Fix the test for Jit that didn't expect line numbers;
4) Minor refactoring:
a) in ProcessTicks;
b) rename enqueue_order_ to last_recorded_code_event_id_ for better
readability;
c) rename dequeue_order_ to last_processed_code_event_id_ and make it a
member
for better readability;
BUG=
TEST=test-profile-generator/LineNumber
Please review this at https://codereview.chromium.org/18058008/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/compiler.cc
M src/cpu-profiler-inl.h
M src/cpu-profiler.h
M src/cpu-profiler.cc
M src/log.cc
M test/cctest/test-api.cc
M test/cctest/test-profile-generator.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
