Not looking good yet.
https://codereview.chromium.org/18751003/diff/1/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/18751003/diff/1/src/hydrogen-instructions.cc#newcode1695
src/hydrogen-instructions.cc:1695: HConstant::cast(value())->Hashcode()
== target_unique_id_.Hashcode())
This might lead to hash collisions for values that are actually not
equal. Better introduce a HConstant::IsUniqueValue(UniqueValueId id)
that does a real comparison of the ids or returns false if the HConstant
doesn't have an id.
https://codereview.chromium.org/18751003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
