https://codereview.chromium.org/18058008/diff/1/src/cpu-profiler.cc
File src/cpu-profiler.cc (right):
https://codereview.chromium.org/18058008/diff/1/src/cpu-profiler.cc#newcode81
src/cpu-profiler.cc:81: while (ProcessCodeEvent()) { }
On 2013/07/05 13:10:00, Yury Semikhatsky wrote:
Why do we have to do this processing on the main thread? It slows down
the start
and adds access to the code map from one more thread.
reverted
https://codereview.chromium.org/18058008/diff/1/src/cpu-profiler.cc#newcode86
src/cpu-profiler.cc:86: void ProfilerEventsProcessor::Stop() {
On 2013/07/05 13:10:00, Yury Semikhatsky wrote:
StopAndJoin or StopSynchronously.
Done.
https://codereview.chromium.org/18058008/diff/1/src/cpu-profiler.cc#newcode468
src/cpu-profiler.cc:468: processor_->Start();
reverted
https://codereview.chromium.org/18058008/diff/1/src/cpu-profiler.h
File src/cpu-profiler.h (right):
https://codereview.chromium.org/18058008/diff/1/src/cpu-profiler.h#newcode158
src/cpu-profiler.h:158: void Start();
On 2013/07/05 13:10:00, Yury Semikhatsky wrote:
There is already non-virtual method Start in Thread class.
reverted
https://codereview.chromium.org/18058008/diff/1/src/cpu-profiler.h#newcode185
src/cpu-profiler.h:185: unsigned last_recorded_code_event_id_;
On 2013/07/05 13:10:00, Yury Semikhatsky wrote:
last_code_event_id_
Done.
https://codereview.chromium.org/18058008/diff/1/src/log.cc
File src/log.cc (left):
https://codereview.chromium.org/18058008/diff/1/src/log.cc#oldcode1667
src/log.cc:1667: // Can't distinguish eval and script here, so always
use Script.
On 2013/07/05 13:10:00, Yury Semikhatsky wrote:
Revert this line?
Done.
https://codereview.chromium.org/18058008/diff/1/src/log.cc
File src/log.cc (right):
https://codereview.chromium.org/18058008/diff/1/src/log.cc#newcode1677
src/log.cc:1677: isolate_->heap()->empty_string(), line_num + 1));
On 2013/07/05 13:10:00, Yury Semikhatsky wrote:
You can do line_num = line_num + 1 once outside if block.
Done.
https://codereview.chromium.org/18058008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
