LGTM with one comment. Nice cleanup.
https://codereview.chromium.org/18154004/diff/2001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/18154004/diff/2001/src/hydrogen.cc#newcode8300
src/hydrogen.cc:8300: HInstruction* instr = new(zone())
HInvokeFunction(context, function, 3);
This will introduce an additional check that compares formal parameter
count against the actually passed number of parameters. I am fine with
landing this change if there is no performance impact due to this
additional check. But please leave a TODO here sayin that we should make
HInvokeFunction smarter when we know the formal parameter count at
compile time.
https://codereview.chromium.org/18154004/diff/2001/src/hydrogen.cc#newcode9115
src/hydrogen.cc:9115: HInstruction* result = new(zone())
HInvokeFunction(context, function, 2);
Likewise.
https://codereview.chromium.org/18154004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
