Revision: 15542
Author: [email protected]
Date: Mon Jul 8 02:07:57 2013
Log: Make test-heap/TestInternalWeakLists pass with the i18n extension
loaded
[email protected]
BUG=v8:2745
Review URL: https://codereview.chromium.org/18654006
Patch from Jochen Eisinger <[email protected]>.
http://code.google.com/p/v8/source/detail?r=15542
Modified:
/branches/bleeding_edge/test/cctest/test-heap.cc
=======================================
--- /branches/bleeding_edge/test/cctest/test-heap.cc Tue Jul 2 08:32:46
2013
+++ /branches/bleeding_edge/test/cctest/test-heap.cc Mon Jul 8 02:07:57
2013
@@ -1327,6 +1327,11 @@
for (int i = 0; i < kNumTestContexts; i++) {
ctx[i] = v8::Context::New(v8::Isolate::GetCurrent());
+ // Collect garbage that might have been created by one of the
+ // installed extensions.
+ isolate->compilation_cache()->Clear();
+ heap->CollectAllGarbage(Heap::kNoGCFlags);
+
bool opt = (FLAG_always_opt && i::V8::UseCrankshaft());
CHECK_EQ(i + 1, CountNativeContexts());
@@ -1388,6 +1393,7 @@
}
// Force compilation cache cleanup.
+ HEAP->NotifyContextDisposed();
HEAP->CollectAllGarbage(Heap::kNoGCFlags);
// Dispose the native contexts one by one.
@@ -3011,6 +3017,10 @@
i::FLAG_harmony_typed_arrays = false;
i::FLAG_harmony_array_buffer = false;
+ // Disable loading the i18n extension which breaks the assumptions of
this
+ // test about the heap layout.
+ i::FLAG_enable_i18n = false;
+
CcTest::InitializeVM();
Isolate* isolate = Isolate::Current();
Heap* heap = isolate->heap();
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
