LGTM
https://chromiumcodereview.appspot.com/14142005/diff/41001/src/arm/stub-cache-arm.cc
File src/arm/stub-cache-arm.cc (right):
https://chromiumcodereview.appspot.com/14142005/diff/41001/src/arm/stub-cache-arm.cc#newcode448
src/arm/stub-cache-arm.cc:448: masm,
Nit: arguments fit in one or two lines.
https://chromiumcodereview.appspot.com/14142005/diff/41001/src/arm/stub-cache-arm.cc#newcode475
src/arm/stub-cache-arm.cc:475: Label* miss_label,
Can we use "miss" instead of "miss_label"?
https://chromiumcodereview.appspot.com/14142005/diff/41001/src/arm/stub-cache-arm.cc#newcode1316
src/arm/stub-cache-arm.cc:1316: __ bind(miss);
Using GenerateRestoreName instead these two lines would be more
descriptive.
https://chromiumcodereview.appspot.com/14142005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
