lgtm
https://codereview.chromium.org/18596005/diff/22001/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/18596005/diff/22001/src/hydrogen-instructions.cc#newcode3043
src/hydrogen-instructions.cc:3043: HType
HInnerAllocatedObject::CalculateInferredType() {
Can put this in the header.
https://codereview.chromium.org/18596005/diff/22001/src/hydrogen-instructions.cc#newcode3224
src/hydrogen-instructions.cc:3224:
Add comment to the effect of "try to fold allocations together with
their dominating allocations"
https://codereview.chromium.org/18596005/diff/22001/src/hydrogen-instructions.cc#newcode3246
src/hydrogen-instructions.cc:3246: Representation::None(),
I think you want Representation::Tagged()
https://codereview.chromium.org/18596005/diff/22001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/18596005/diff/22001/src/hydrogen-instructions.h#newcode4982
src/hydrogen-instructions.h:4982:
Whitespace changes.
https://codereview.chromium.org/18596005/diff/22001/src/hydrogen.h
File src/hydrogen.h (right):
https://codereview.chromium.org/18596005/diff/22001/src/hydrogen.h#newcode241
src/hydrogen.h:241: bool Done() { return instr_ == NULL; }
While you're here, would you mind adding "inline" and "const" keywords?
https://codereview.chromium.org/18596005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
