LGTM with nit.
https://codereview.chromium.org/18899002/diff/2001/src/icu_util.cc
File src/icu_util.cc (right):
https://codereview.chromium.org/18899002/diff/2001/src/icu_util.cc#newcode46
src/icu_util.cc:46: if (!module)
nit: V8 style prefers to either have the then-clause on the same line
(i.e. "if (!module) return false;") or use {}.
Again below.
https://codereview.chromium.org/18899002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
