Revision: 15573
Author: [email protected]
Date: Tue Jul 9 05:31:59 2013
Log: ARM: Do not omit the write-barrier if the input value is a smi.
The input value isn't what is written into the field if the representation
is double. A heap-number is written to the field instead; which requires a
write-barrier.
BUG=chromium:254570
[email protected]
Review URL: https://chromiumcodereview.appspot.com/18854018
http://code.google.com/p/v8/source/detail?r=15573
Modified:
/branches/bleeding_edge/src/arm/stub-cache-arm.cc
=======================================
--- /branches/bleeding_edge/src/arm/stub-cache-arm.cc Tue Jul 9 01:22:41
2013
+++ /branches/bleeding_edge/src/arm/stub-cache-arm.cc Tue Jul 9 05:31:59
2013
@@ -570,9 +570,6 @@
}
if (!FLAG_track_fields || !representation.IsSmi()) {
- // Skip updating write barrier if storing a smi.
- __ JumpIfSmi(value_reg, &exit);
-
// Update the write barrier for the array address.
if (!FLAG_track_double_fields || !representation.IsDouble()) {
__ mov(storage_reg, value_reg);
@@ -599,9 +596,6 @@
}
if (!FLAG_track_fields || !representation.IsSmi()) {
- // Skip updating write barrier if storing a smi.
- __ JumpIfSmi(value_reg, &exit);
-
// Update the write barrier for the array address.
if (!FLAG_track_double_fields || !representation.IsDouble()) {
__ mov(storage_reg, value_reg);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
