Revision: 15577
Author: [email protected]
Date: Tue Jul 9 08:58:31 2013
Log: MIPS: Do not omit the write-barrier if the input value is a smi.
Port r15573 (3954d53)
Original commit message:
ARM: Do not omit the write-barrier if the input value is a smi.
The input value isn't what is written into the field if the representation
is double. A heap-number is written to the field instead; which requires a
write-barrier.
BUG=chromium:254570
Review URL: https://codereview.chromium.org/18118010
Patch from Balazs Kilvady <[email protected]>.
http://code.google.com/p/v8/source/detail?r=15577
Modified:
/branches/bleeding_edge/src/mips/stub-cache-mips.cc
=======================================
--- /branches/bleeding_edge/src/mips/stub-cache-mips.cc Tue Jul 9 08:54:43
2013
+++ /branches/bleeding_edge/src/mips/stub-cache-mips.cc Tue Jul 9 08:58:31
2013
@@ -560,9 +560,6 @@
}
if (!FLAG_track_fields || !representation.IsSmi()) {
- // Skip updating write barrier if storing a smi.
- __ JumpIfSmi(value_reg, &exit);
-
// Update the write barrier for the array address.
if (!FLAG_track_double_fields || !representation.IsDouble()) {
__ mov(storage_reg, value_reg);
@@ -589,9 +586,6 @@
}
if (!FLAG_track_fields || !representation.IsSmi()) {
- // Skip updating write barrier if storing a smi.
- __ JumpIfSmi(value_reg, &exit);
-
// Update the write barrier for the array address.
if (!FLAG_track_double_fields || !representation.IsDouble()) {
__ mov(storage_reg, value_reg);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
