LGTM with comments.
Thanks for your patience with all the iterations on this CL! I really like
the
latest version.
https://codereview.chromium.org/18846002/diff/15001/build/android.gypi
File build/android.gypi (right):
https://codereview.chromium.org/18846002/diff/15001/build/android.gypi#newcode30
build/android.gypi:30: #
http://src.chromium.org/viewvc/chrome/trunk/src/build/toolchain.gypi
accidental edit? I don't think Chromium has a toolchain.gypi.
https://codereview.chromium.org/18846002/diff/15001/src/third_party/vtune/v8vtune.gyp
File src/third_party/vtune/v8vtune.gyp (right):
https://codereview.chromium.org/18846002/diff/15001/src/third_party/vtune/v8vtune.gyp#newcode32
src/third_party/vtune/v8vtune.gyp:32: 'includes':
['../build/toolchain.gypi', '../build/features.gypi'],
Why did the relative path change? Are you sure this still works?
https://codereview.chromium.org/18846002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
