Status: Accepted
Owner: [email protected]
CC: [email protected],  [email protected],  [email protected]
Labels: Type-Bug Priority-Medium

New issue 2774 by [email protected]: CountOperation and CompoundAssignment provide type feedback for observed maps, breaking crankshaft.
http://code.google.com/p/v8/issues/detail?id=2774

This fails since I unified CountOperation and CompoundAssignment with other assignments because the design was inconsistent. We are not supposed to get any type feedback in crankshaft for any observed assignments, so we shouldn't be filtering them out there.

The following test fails:

function add(o) {
  o.x++; // CountOperation.
  o.x += 5; // CompoundAssignment.
}

var count = 0;

function cl(c) {
  count++;
}

var o = {x:0};
Object.observe(o, cl);

assertEquals(0, count);

add(o);
Object.deliverChangeRecords(cl);
assertEquals(1, count);

add(o);
Object.deliverChangeRecords(cl);
assertEquals(2, count);

%OptimizeFunctionOnNextCall(add);
add(o);
Object.deliverChangeRecords(cl);
assertEquals(3, count);


--
You received this message because this project is configured to send all issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to