https://codereview.chromium.org/18356008/diff/1/src/arm/deoptimizer-arm.cc
File src/arm/deoptimizer-arm.cc (right):
https://codereview.chromium.org/18356008/diff/1/src/arm/deoptimizer-arm.cc#newcode478
src/arm/deoptimizer-arm.cc:478: __ add(r4, sp,
Operand(kSavedRegistersAreaSize + (2 * kPointerSize)));
Why is LAZY handled differently? Shouldn't all four cases be uniform
now?
https://codereview.chromium.org/18356008/diff/1/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):
https://codereview.chromium.org/18356008/diff/1/src/arm/lithium-codegen-arm.cc#newcode360
src/arm/lithium-codegen-arm.cc:360: __ b(&needs_frame_is_call);
Here and else where, remove is_call from variable names, it's no longer
needed for disambiguation.
https://codereview.chromium.org/18356008/diff/1/src/mips/deoptimizer-mips.cc
File src/mips/deoptimizer-mips.cc (right):
https://codereview.chromium.org/18356008/diff/1/src/mips/deoptimizer-mips.cc#newcode463
src/mips/deoptimizer-mips.cc:463: if (type() == EAGER || type() == SOFT
|| type() == OSR) {
As with ARM, why the special handling of LAZY?
https://codereview.chromium.org/18356008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
