Revision: 15590
Author: [email protected]
Date: Wed Jul 10 05:19:37 2013
Log: Revert "Calls to HCheckFunction can be eliminated if the value is
an HConstant"
This reverts commit 3f96122cc572f7a0b638c30f65328c3cb3666795.
BUG=
[email protected]
Review URL: https://codereview.chromium.org/18998003
http://code.google.com/p/v8/source/detail?r=15590
Modified:
/branches/bleeding_edge/src/hydrogen-instructions.cc
/branches/bleeding_edge/src/hydrogen-instructions.h
/branches/bleeding_edge/src/objects.cc
=======================================
--- /branches/bleeding_edge/src/hydrogen-instructions.cc Wed Jul 10
02:02:23 2013
+++ /branches/bleeding_edge/src/hydrogen-instructions.cc Wed Jul 10
05:19:37 2013
@@ -1688,14 +1688,6 @@
value()->PrintNameTo(stream);
stream->Add(" %p", *target());
}
-
-
-HValue* HCheckFunction::Canonicalize() {
- return (value()->IsConstant() &&
- HConstant::cast(value())->UniqueValueIdsMatch(target_unique_id_))
- ? NULL
- : this;
-}
const char* HCheckInstanceType::GetCheckName() {
=======================================
--- /branches/bleeding_edge/src/hydrogen-instructions.h Wed Jul 10 02:02:23
2013
+++ /branches/bleeding_edge/src/hydrogen-instructions.h Wed Jul 10 05:19:37
2013
@@ -2836,8 +2836,6 @@
virtual void PrintDataTo(StringStream* stream);
virtual HType CalculateInferredType();
- virtual HValue* Canonicalize();
-
#ifdef DEBUG
virtual void Verify();
#endif
@@ -3410,11 +3408,6 @@
unique_id_ = UniqueValueId(handle_);
}
}
-
- bool UniqueValueIdsMatch(UniqueValueId other) {
- if (!has_double_value_) return unique_id_ == other;
- return false;
- }
#ifdef DEBUG
virtual void Verify() { }
=======================================
--- /branches/bleeding_edge/src/objects.cc Mon Jul 8 08:41:06 2013
+++ /branches/bleeding_edge/src/objects.cc Wed Jul 10 05:19:37 2013
@@ -15821,8 +15821,7 @@
Handle<Object> value) {
Isolate* isolate = cell->GetIsolate();
Handle<Type> old_type(cell->type(), isolate);
- Handle<Type> new_type((value->IsSmi() || value->IsJSFunction() ||
- value->IsUndefined())
+ Handle<Type> new_type((value->IsSmi() || value->IsUndefined())
? Type::Constant(value, isolate)
: Type::Any(), isolate);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
