On 2013/07/10 09:57:33, mvstanton wrote:
lgtm.
Have a look at the one comment.
Very nice!
--Michael
https://chromiumcodereview.appspot.com/18041003/diff/64001/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):
https://chromiumcodereview.appspot.com/18041003/diff/64001/src/ia32/lithium-codegen-ia32.cc#newcode988
src/ia32/lithium-codegen-ia32.cc:988: for (int i = 0; i <
x87_stack_depth_;
i++)
__ fstp(0);
Put the x87 stack flushing operation in a method call like the other ops,
which
are well encapsulated.
sorry found some potential problems, PTAL
https://codereview.chromium.org/18041003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
