https://codereview.chromium.org/18881004/diff/1/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):
https://codereview.chromium.org/18881004/diff/1/src/code-stubs-hydrogen.cc#newcode974
src/code-stubs-hydrogen.cc:974: BuildNewSpaceArrayCheck(elements_length,
to_kind);
On 2013/07/10 09:52:37, danno wrote:
Why can't you use the helper function "BuildGrowElementsCapacity" for
this line
and the following ~10 or so?
Done.
https://codereview.chromium.org/18881004/diff/5002/src/code-stubs.h
File src/code-stubs.h (right):
https://codereview.chromium.org/18881004/diff/5002/src/code-stubs.h#newcode88
src/code-stubs.h:88: V(ElementsTransitionAndStoreNonStrict) \
I had another look at KeyedStoreIC_Miss and KeyedStore ICs. If you use a
StoreKeyedIC, you can get the strictness from the calling IC, it really
is redundant on the code stub.
Please create a KeyedStoreIC in the transition and store stub runtime
call in C++, and use it to extract the strictness like we do for the
plain KeyedStoreICs.
Sorry for the noise :-/
https://codereview.chromium.org/18881004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
