Reviewers: Jakob,
Message:
PTAL
Description:
Suppress array bounds check for nacl build.
The NaCl and the ARM builder started failing to compile at revision 15593
with
spurious array bounds warnings.
The ARM builder will be fixed by updating the cross-compiler version. Since
the
nacl compiler comes with the nacl toolchain, the warning will be suppressed
for
that builder.
See also:
http://gcc.gnu.org/bugzilla/buglist.cgi?quicksearch=array%20subscript%20is%20above%20array%20bounds
Please review this at https://codereview.chromium.org/19009003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M Makefile.nacl
M build/toolchain.gypi
Index: Makefile.nacl
diff --git a/Makefile.nacl b/Makefile.nacl
index
0c98021ed1e234c1a8a4bf8cd0bac17d5245145b..0d053b116125ee6a9f24b0186dc9706be9a8d4e8
100644
--- a/Makefile.nacl
+++ b/Makefile.nacl
@@ -93,4 +93,5 @@ $(NACL_MAKEFILES):
CXX=${NACL_CXX} \
build/gyp/gyp --generator-output="${OUTDIR}" build/all.gyp \
-Ibuild/standalone.gypi --depth=. \
- -S.$(subst .,,$(suffix $@)) $(GYPFLAGS)
+ -S.$(subst .,,$(suffix $@)) $(GYPFLAGS) \
+ -Dwno_array_bounds=-Wno-array-bounds
Index: build/toolchain.gypi
diff --git a/build/toolchain.gypi b/build/toolchain.gypi
index
ec73a315c2fc3194d4cf6afc3de3ecf63adea89d..95e2cd2ef595a9ac1124ab3d5238f50d608d1fd4
100644
--- a/build/toolchain.gypi
+++ b/build/toolchain.gypi
@@ -77,6 +77,9 @@
'werror%': '-Werror',
# For a shared library build, results in "libv8-<(soname_version).so".
'soname_version%': '',
+
+ # Allow to suppress the array bounds warning (default is no
suppression).
+ 'wno_array_bounds%': '',
},
'target_defaults': {
'conditions': [
@@ -465,7 +468,8 @@
'conditions': [
['OS=="linux" or OS=="freebsd" or OS=="openbsd" or
OS=="netbsd"', {
'cflags':
[ '-Wall', '<(werror)', '-W', '-Wno-unused-parameter',
- '-Wnon-virtual-dtor', '-Woverloaded-virtual' ],
+ '-Wnon-virtual-dtor', '-Woverloaded-virtual',
+ '<(wno_array_bounds)' ],
'conditions': [
['v8_optimized_debug==1', {
'cflags!': [
@@ -530,6 +534,7 @@
'-fdata-sections',
'-ffunction-sections',
'-O3',
+ '<(wno_array_bounds)',
],
'conditions': [
[ 'gcc_version==44 and clang==0', {
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
