Revision: 15608
Author: [email protected]
Date: Wed Jul 10 09:21:17 2013
Log: Suppress array bounds check for nacl build.
The NaCl and the ARM builder started failing to compile at revision 15593
with spurious array bounds warnings.
The ARM builder will be fixed by updating the cross-compiler version. Since
the nacl compiler comes with the nacl toolchain, the warning will be
suppressed for that builder.
See also:
http://gcc.gnu.org/bugzilla/buglist.cgi?quicksearch=array%20subscript%20is%20above%20array%20bounds
[email protected]
Review URL: https://codereview.chromium.org/19009003
http://code.google.com/p/v8/source/detail?r=15608
Modified:
/branches/bleeding_edge/Makefile.nacl
/branches/bleeding_edge/build/toolchain.gypi
=======================================
--- /branches/bleeding_edge/Makefile.nacl Tue May 28 08:33:39 2013
+++ /branches/bleeding_edge/Makefile.nacl Wed Jul 10 09:21:17 2013
@@ -93,4 +93,5 @@
CXX=${NACL_CXX} \
build/gyp/gyp --generator-output="${OUTDIR}" build/all.gyp \
-Ibuild/standalone.gypi --depth=. \
- -S.$(subst .,,$(suffix $@)) $(GYPFLAGS)
+ -S.$(subst .,,$(suffix $@)) $(GYPFLAGS) \
+ -Dwno_array_bounds=-Wno-array-bounds
=======================================
--- /branches/bleeding_edge/build/toolchain.gypi Wed Jul 10 08:21:43 2013
+++ /branches/bleeding_edge/build/toolchain.gypi Wed Jul 10 09:21:17 2013
@@ -77,6 +77,9 @@
'werror%': '-Werror',
# For a shared library build, results in "libv8-<(soname_version).so".
'soname_version%': '',
+
+ # Allow to suppress the array bounds warning (default is no
suppression).
+ 'wno_array_bounds%': '',
},
'target_defaults': {
'conditions': [
@@ -465,7 +468,8 @@
'conditions': [
['OS=="linux" or OS=="freebsd" or OS=="openbsd" or
OS=="netbsd"', {
'cflags':
[ '-Wall', '<(werror)', '-W', '-Wno-unused-parameter',
- '-Wnon-virtual-dtor', '-Woverloaded-virtual' ],
+ '-Wnon-virtual-dtor', '-Woverloaded-virtual',
+ '<(wno_array_bounds)' ],
'conditions': [
['v8_optimized_debug==1', {
'cflags!': [
@@ -530,6 +534,7 @@
'-fdata-sections',
'-ffunction-sections',
'-O3',
+ '<(wno_array_bounds)',
],
'conditions': [
[ 'gcc_version==44 and clang==0', {
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
