https://codereview.chromium.org/18998004/diff/2001/src/store-buffer.cc
File src/store-buffer.cc (right):
https://codereview.chromium.org/18998004/diff/2001/src/store-buffer.cc#newcode426
src/store-buffer.cc:426: Address& map_field =
Memory::Address_at(object->address());
On 2013/07/10 17:06:35, titzer wrote:
I'm a little dedup, short and stout. Rip me over and factor me out!
Done.
https://codereview.chromium.org/18998004/diff/2001/src/store-buffer.cc#newcode596
src/store-buffer.cc:596: }
On 2013/07/10 17:06:35, titzer wrote:
BTW, do you still want to call the slot callback if the object is
dead?
As soon as we clear the todo in the callback, we can make that call
conditional.
https://codereview.chromium.org/18998004/diff/2001/src/store-buffer.h
File src/store-buffer.h (right):
https://codereview.chromium.org/18998004/diff/2001/src/store-buffer.h#newcode86
src/store-buffer.h:86: void IteratePointersToNewSpace(ObjectSlotCallback
callback, bool clear_maps);
On 2013/07/10 17:06:35, titzer wrote:
Boolean flags of doom be gone! Recommend to have two separate methods,
one which
clears and one which does not clear. The private implementation can
use internal
booleans to avoid duplicating the guts, but the public interface
should be more
well-defined.
Either that, or you could have the callback itself doing the
clearing...
Done.
https://codereview.chromium.org/18998004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
