DBC
https://codereview.chromium.org/18214005/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/18214005/diff/1/src/runtime.cc#newcode8365
src/runtime.cc:8365: // mark the top frame as do not optimize
nit: Begin with capitalization, end with punctuation. Again below.
https://codereview.chromium.org/18214005/diff/1/src/runtime.cc#newcode8367
src/runtime.cc:8367: if (!it.done())
MarkNeverOptimize(JSFunction::cast(it.frame()->function()));
Instead of rolling your own MarkNeverOptimize, I think you should just
call:
JSFunction::cast(it.frame()->function())->shared()->DisableOptimization("%NeverOptimize");
That function does all the right things.
https://codereview.chromium.org/18214005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
