On 2013/07/08 10:54:19, weiliang.lin2 wrote:
On 2013/07/08 09:00:45, Yang wrote:
> On 2013/07/06 13:32:26, weiliang.lin2 wrote:
> > PTAL
>
> Drive-by comment:
>
> this changes the semantics of set_optimization_disabled and its comment
would
no
> longer be valid. The current behavior is that if optimization is
disabled
for
> the shared function info, the shared code is also disabled for
optimization,
but
> if optimization is enabled again for the shared function info, the
shared
code
> is not not automatically enabled as well for optimization.
>
> While the change is fine, it takes away some flexibility and of course
the
> comment needs to be changed.
Thanks for comments~ Addressed comment
Yes, you are right. It seems to take away some flexibility although when
original V8 code changes shared info optimization, it will always change
the
shared code optimizable at the same time.
If this commit is not necessary, just close it.
https://codereview.chromium.org/18158007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
