On 2013/07/12 07:54:28, Benedikt Meurer wrote:
https://codereview.chromium.org/18431004/diff/1/src/platform-macos.cc
File src/platform-macos.cc (right):
https://codereview.chromium.org/18431004/diff/1/src/platform-macos.cc#newcode194
src/platform-macos.cc:194: if (backtrace == NULL) return;
On 2013/07/12 07:46:02, Dmitry Lomov (chromium) wrote:
> This code looks a copy of the code in platform-linux.cc
> Can we share it, possibly parameterized with function pointer to
backtrace
> function?
It's basically a copy, yes. Where would we put this template? In
platform-posix.h?
We could put all stack trace related stuff to platform-posix.{cc,h} with
some
#ifdef's. There's just Solaris which is totally different here.
https://codereview.chromium.org/18431004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
