LGTM with comments
https://codereview.chromium.org/18429005/diff/16001/src/ast.cc
File src/ast.cc (right):
https://codereview.chromium.org/18429005/diff/16001/src/ast.cc#newcode76
src/ast.cc:76: VariableProxy* var_proxy =
static_cast<VariableProxy*>(this);
Instead of these two lines, use AsVariableProxy() and return false if
it's NULL.
https://codereview.chromium.org/18429005/diff/16001/src/ast.cc#newcode81
src/ast.cc:81: strncmp(*var_proxy->name()->ToCString(), "undefined", 10)
== 0;
You should be able to say
var->name()->Equals(isolate()->heap()->undefined_string())
especially since that will take advantage of the string internalization
the parser performs.
https://codereview.chromium.org/18429005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
