Addressed comments. PTAL.
https://codereview.chromium.org/18774002/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/18774002/diff/1/src/objects.cc#newcode716
src/objects.cc:716: Handle<NameDictionary> dictionary =
handle(object->property_dictionary());
On 2013/07/12 12:37:34, Toon Verwaest wrote:
What about just Handle<NameDictionary>
dictionary(object->property_dictonary())?
Done.
https://codereview.chromium.org/18774002/diff/1/src/objects.cc#newcode3551
src/objects.cc:3551: return *JSProxy::DeletePropertyWithHandler(object,
name, mode);
On 2013/07/12 12:37:34, Toon Verwaest wrote:
It seems a bit scary to call from non-handlified code into handlified
code. Can
we get rid of this method altogether and make its caller also
handlified?
Done.
https://codereview.chromium.org/18774002/diff/1/src/objects.cc#newcode5131
src/objects.cc:5131: CALL_HEAP_FUNCTION(isolate,
object->DeleteElement(index, mode), Object);
On 2013/07/12 12:37:34, Toon Verwaest wrote:
What about just calling into the handlified version here?
Done.
https://codereview.chromium.org/18774002/diff/1/src/objects.cc#newcode5182
src/objects.cc:5182: return
JSProxy::cast(this)->DeleteElementWithHandler(index, mode);
On 2013/07/12 12:37:34, Toon Verwaest wrote:
I'd keep this one handlified.
Done.
https://codereview.chromium.org/18774002/diff/1/src/objects.cc#newcode5184
src/objects.cc:5184: return JSObject::cast(this)->DeleteElement(index,
mode);
On 2013/07/12 12:37:34, Toon Verwaest wrote:
... and use CALL_HEAP_FUNCTION here.
Done.
https://codereview.chromium.org/18774002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
