https://codereview.chromium.org/19588002/diff/2001/src/ia32/stub-cache-ia32.cc
File src/ia32/stub-cache-ia32.cc (right):

https://codereview.chromium.org/19588002/diff/2001/src/ia32/stub-cache-ia32.cc#newcode1136
src/ia32/stub-cache-ia32.cc:1136: __ mov(scratch1,
Handle<Map>(object->map()));
On 2013/07/17 15:03:30, Michael Starzinger wrote:
The StubCompiler::CheckPrototypes() helper is used in many places,
even several
times within the same stub. So I think this should be hoisted out of
this helper
to only add the embedded map at the top of each stub that actually
needs it.

To be precise, this should go into
CallStubCompiler::CompileCallConstant(). Toon also made a good point,
the CheckPrototypes is also used for loads and stores, not just calls.

https://codereview.chromium.org/19588002/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to