lgtm with nits
https://codereview.chromium.org/19594002/diff/1/src/accessors.cc
File src/accessors.cc (right):
https://codereview.chromium.org/19594002/diff/1/src/accessors.cc#newcode451
src/accessors.cc:451: MaybeObject*
Accessors::FunctionGetPrototype(Object* object, void*) {
This function doesn't return failure anymore, so change the return-type
to Object*.
https://codereview.chromium.org/19594002/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/19594002/diff/1/src/objects.cc#newcode9555
src/objects.cc:9555: Handle<Map> new_map =
Map::Copy(Handle<Map>(function->initial_map()));
Lets use handle(function->initial_map) since it's shorter. Also below
for Handle<Context>.
https://codereview.chromium.org/19594002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
