Thanks for the review. Comments addressed.
https://codereview.chromium.org/19748003/diff/1/src/deoptimizer.h
File src/deoptimizer.h (right):
https://codereview.chromium.org/19748003/diff/1/src/deoptimizer.h#newcode513
src/deoptimizer.h:513: void SetCallerPc(unsigned offset, intptr_t value)
{
On 2013/07/18 10:51:24, danno wrote:
A difference copy of this routine should be in the platform-specific
files.
Done.
https://codereview.chromium.org/19748003/diff/1/src/deoptimizer.h#newcode516
src/deoptimizer.h:516: SetFrameSlot(offset + kPointerSize, 0);
On 2013/07/18 10:51:24, danno wrote:
This assumes little endianess, I would much prefer to just have a
different copy
of this short routine on each platform.
Done.
https://codereview.chromium.org/19748003/diff/1/src/deoptimizer.h#newcode521
src/deoptimizer.h:521: void SetCallerFp(unsigned offset, intptr_t value)
{
On 2013/07/18 10:51:24, danno wrote:
Same as above, there should be a different implementation of this
function in
each deoptimizer-XXX file for each platform.
Done.
https://codereview.chromium.org/19748003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
