lgtm with comments.
https://codereview.chromium.org/19638003/diff/2001/src/accessors.cc
File src/accessors.cc (right):
https://codereview.chromium.org/19638003/diff/2001/src/accessors.cc#newcode582
src/accessors.cc:582: isolate, Accessors::FunctionGetArguments(*object,
0), Object);
The call sites always have a comment that this cannot return a failure.
Can we just assert it and create a handle from it directly?
https://codereview.chromium.org/19638003/diff/2001/src/accessors.h
File src/accessors.h (right):
https://codereview.chromium.org/19638003/diff/2001/src/accessors.h#newcode81
src/accessors.h:81: static Handle<Object>
FunctionGetArguments(Handle<Object> object);
Call sites of this always pass a Handle<JSFunction> and expect a
Handle<JSObject> as return value. Can we reflect that?
https://codereview.chromium.org/19638003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
