High-level comment: I consider HType deprecated, to be replaced by a Type
(or
more likely a Bounds struct) being stored in every HValue.
I agree in theory, but currently this is the only place where we have type
guarantees recorded and it would be a waste not to consume this information
if
it is there already....
https://codereview.chromium.org/19271008/diff/23001/src/hydrogen-instructions.cc#newcode466
src/hydrogen-instructions.cc:466: if (IsSmi()) return
handle(::v8::internal::Type::Smi(), isolate);
This is not a generic implementation of intersection. At the very least,
you
should ASSERT(type->Is(Type::Smi())).
Ok maybe this should not be called intersect.
If HType says it is a smi, then this is unconditionally true. So if Type
says
something else, then our typefeedback was just wrong, but it don't think we
can
assert this...
https://codereview.chromium.org/19271008/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
