Reviewers: danno,
Message:
This is danno's comment on https://codereview.chromium.org/18014003.
Description:
Rename emitq to emit for X64
Please review this at https://codereview.chromium.org/19752004/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
src/x64/assembler-x64-inl.h
src/x64/assembler-x64.h
src/x64/assembler-x64.cc
Index: src/x64/assembler-x64-inl.h
===================================================================
--- src/x64/assembler-x64-inl.h (revision 15744)
+++ src/x64/assembler-x64-inl.h (working copy)
@@ -45,21 +45,21 @@
static const byte kCallOpcode = 0xE8;
+void Assembler::emit(uintptr_t x, RelocInfo::Mode rmode) {
+ Memory::uintptr_at(pc_) = x;
+ if (!RelocInfo::IsNone(rmode)) {
+ RecordRelocInfo(rmode, x);
+ }
+ pc_ += sizeof(uintptr_t);
+}
+
+
void Assembler::emitl(uint32_t x) {
Memory::uint32_at(pc_) = x;
pc_ += sizeof(uint32_t);
}
-void Assembler::emitq(uint64_t x, RelocInfo::Mode rmode) {
- Memory::uint64_at(pc_) = x;
- if (!RelocInfo::IsNone(rmode)) {
- RecordRelocInfo(rmode, x);
- }
- pc_ += sizeof(uint64_t);
-}
-
-
void Assembler::emitw(uint16_t x) {
Memory::uint16_at(pc_) = x;
pc_ += sizeof(uint16_t);
Index: src/x64/assembler-x64.cc
===================================================================
--- src/x64/assembler-x64.cc (revision 15744)
+++ src/x64/assembler-x64.cc (working copy)
@@ -1377,7 +1377,7 @@
EnsureSpace ensure_space(this);
emit(0x48); // REX.W
emit(0xA1);
- emitq(reinterpret_cast<uintptr_t>(value), mode);
+ emit(reinterpret_cast<uintptr_t>(value), mode);
}
@@ -1529,7 +1529,7 @@
EnsureSpace ensure_space(this);
emit_rex_64(dst);
emit(0xB8 | dst.low_bits());
- emitq(reinterpret_cast<uintptr_t>(value), rmode);
+ emit(reinterpret_cast<uintptr_t>(value), rmode);
}
@@ -1549,7 +1549,7 @@
EnsureSpace ensure_space(this);
emit_rex_64(dst);
emit(0xB8 | dst.low_bits());
- emitq(value, rmode);
+ emit(value, rmode);
}
@@ -1606,7 +1606,7 @@
ASSERT(!HEAP->InNewSpace(*value));
emit_rex_64(dst);
emit(0xB8 | dst.low_bits());
- emitq(reinterpret_cast<uintptr_t>(value.location()), mode);
+ emit(reinterpret_cast<uintptr_t>(value.location()), mode);
}
}
@@ -1998,7 +1998,7 @@
EnsureSpace ensure_space(this);
emit(0x48); // REX.W
emit(0xA3);
- emitq(reinterpret_cast<uintptr_t>(dst), mode);
+ emit(reinterpret_cast<uintptr_t>(dst), mode);
}
Index: src/x64/assembler-x64.h
===================================================================
--- src/x64/assembler-x64.h (revision 15744)
+++ src/x64/assembler-x64.h (working copy)
@@ -1443,8 +1443,8 @@
void GrowBuffer();
void emit(byte x) { *pc_++ = x; }
+ inline void emit(uintptr_t x, RelocInfo::Mode rmode);
inline void emitl(uint32_t x);
- inline void emitq(uint64_t x, RelocInfo::Mode rmode);
inline void emitw(uint16_t x);
inline void emit_code_target(Handle<Code> target,
RelocInfo::Mode rmode,
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
