Reviewers: Yang, loislo, alph,
Message:
Committed patchset #1 manually as r15753 (presubmit successful).
Description:
Fix Windows compilation after r15750
BUG=None
[email protected]
Committed: https://code.google.com/p/v8/source/detail?r=15753
Please review this at https://codereview.chromium.org/19778003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/circular-queue.h
M src/circular-queue.cc
Index: src/circular-queue.cc
diff --git a/src/circular-queue.cc b/src/circular-queue.cc
index
475b23487a58d2f1bbe3a67f6088aaf986002ce9..3e32e4d2883e15c3f3af3ba598fa7c469b0283b5
100644
--- a/src/circular-queue.cc
+++ b/src/circular-queue.cc
@@ -35,7 +35,7 @@ namespace internal {
SamplingCircularQueue::SamplingCircularQueue(size_t record_size_in_bytes,
size_t
desired_chunk_size_in_bytes,
- int buffer_size_in_chunks)
+ unsigned
buffer_size_in_chunks)
: record_size_(record_size_in_bytes / sizeof(Cell)),
chunk_size_in_bytes_(desired_chunk_size_in_bytes /
record_size_in_bytes *
record_size_in_bytes + sizeof(Cell)),
@@ -46,7 +46,7 @@ SamplingCircularQueue::SamplingCircularQueue(size_t
record_size_in_bytes,
ASSERT(chunk_size_ * sizeof(Cell) == chunk_size_in_bytes_);
ASSERT(buffer_size_in_chunks > 2);
// Mark all chunks as clear.
- for (int i = 0; i < buffer_size_; i += chunk_size_) {
+ for (size_t i = 0; i < buffer_size_; i += chunk_size_) {
buffer_[i] = kClear;
}
Index: src/circular-queue.h
diff --git a/src/circular-queue.h b/src/circular-queue.h
index
239ffe18d2e096abb24fe220b8b38478445fd2b5..4ad4f4b5505356c784e63dd12dd939da526e935e
100644
--- a/src/circular-queue.h
+++ b/src/circular-queue.h
@@ -47,7 +47,7 @@ class SamplingCircularQueue {
// Executed on the application thread.
SamplingCircularQueue(size_t record_size_in_bytes,
size_t desired_chunk_size_in_bytes,
- int buffer_size_in_chunks);
+ unsigned buffer_size_in_chunks);
~SamplingCircularQueue();
// Enqueue returns a pointer to a memory location for storing the next
@@ -88,10 +88,10 @@ class SamplingCircularQueue {
INLINE(void WrapPositionIfNeeded(Cell** pos));
- const int record_size_;
+ const size_t record_size_;
const size_t chunk_size_in_bytes_;
- const int chunk_size_;
- const int buffer_size_;
+ const size_t chunk_size_;
+ const size_t buffer_size_;
Cell* buffer_;
byte* positions_;
ProducerPosition* producer_pos_;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
