LGTM with comments.
https://codereview.chromium.org/18333012/diff/5001/src/x64/code-stubs-x64.cc
File src/x64/code-stubs-x64.cc (right):
https://codereview.chromium.org/18333012/diff/5001/src/x64/code-stubs-x64.cc#newcode634
src/x64/code-stubs-x64.cc:634: // to calculate the result if ecx is the
requested return register.
comments do not apply to x64 registers
https://codereview.chromium.org/18333012/diff/5001/src/x64/code-stubs-x64.cc#newcode671
src/x64/code-stubs-x64.cc:671: __ negl(result_reg);
We don't do zero-extension while moving anywhere. Could it happen that
the upper 32-bit of the result just carries over?
https://codereview.chromium.org/18333012/diff/5001/test/cctest/test-code-stubs-x64.cc
File test/cctest/test-code-stubs-x64.cc (right):
https://codereview.chromium.org/18333012/diff/5001/test/cctest/test-code-stubs-x64.cc#newcode137
test/cctest/test-code-stubs-x64.cc:137:
Why not make it something like
Register source_registers[7] = {rsp, rax, rbx, rcx, rdx, rsi, rdi};
Register dest_registers[6] = {rax, rbx, rcx, rdx, rsi, rdi};
for (int s = 0; s < 7; s++) {
for (int d = 0; d < 6; d++) {
RunAllTruncationTests(
MakeConvertDToIFuncTrampoline(isolate,
source_registers[s],
dest_registers[d]));
}
}
https://codereview.chromium.org/18333012/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
