Revision: 15758
Author:   [email protected]
Date:     Thu Jul 18 10:04:06 2013
Log:      Merged r15577 into 3.19 branch.

MIPS: Do not omit the write-barrier if the input value is a smi.

BUG=chromium:254570

[email protected]

Review URL: https://codereview.chromium.org/19779002
http://code.google.com/p/v8/source/detail?r=15758

Modified:
 /branches/3.19/src/mips/stub-cache-mips.cc
 /branches/3.19/src/version.cc

=======================================
--- /branches/3.19/src/mips/stub-cache-mips.cc  Tue Jun 18 04:54:54 2013
+++ /branches/3.19/src/mips/stub-cache-mips.cc  Thu Jul 18 10:04:06 2013
@@ -594,9 +594,6 @@
     }

     if (!FLAG_track_fields || !representation.IsSmi()) {
-      // Skip updating write barrier if storing a smi.
-      __ JumpIfSmi(value_reg, &exit);
-
       // Update the write barrier for the array address.
       // Pass the now unused name_reg as a scratch register.
       if (!FLAG_track_double_fields || !representation.IsDouble()) {
@@ -626,9 +623,6 @@
     }

     if (!FLAG_track_fields || !representation.IsSmi()) {
-      // Skip updating write barrier if storing a smi.
-      __ JumpIfSmi(value_reg, &exit);
-
       // Update the write barrier for the array address.
       // Ok to clobber receiver_reg and name_reg, since we return.
       if (!FLAG_track_double_fields || !representation.IsDouble()) {
=======================================
--- /branches/3.19/src/version.cc       Wed Jul 17 05:26:55 2013
+++ /branches/3.19/src/version.cc       Thu Jul 18 10:04:06 2013
@@ -35,7 +35,7 @@
 #define MAJOR_VERSION     3
 #define MINOR_VERSION     19
 #define BUILD_NUMBER      18
-#define PATCH_LEVEL       12
+#define PATCH_LEVEL       13
 // Use 1 for candidates and 0 otherwise.
 // (Boolean macro values are not supported by all preprocessors.)
 #define IS_CANDIDATE_VERSION 0

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to